Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unwrap function documentation don't mention implicit copyability #9099

Closed
metajack opened this issue Sep 10, 2013 · 5 comments · Fixed by #16579
Closed

unwrap function documentation don't mention implicit copyability #9099

metajack opened this issue Sep 10, 2013 · 5 comments · Fixed by #16579
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@metajack
Copy link
Contributor

The documentation for Option unwrap (and possibly others) is currently wrong. It does not always move the value, since the value may be implicitly copyable. This needs to be mentioned in the docs, or the types that have unwrap methods should be annotated to make them not implicitly copyable (see #9098).
@metajack
Copy link
Contributor Author

nominating production ready

@catamorphism
Copy link
Contributor

Just a bug

@nikomatsakis
Copy link
Contributor

We should probably not use the term move in general in the docs, preferring instead something more generic.

@emberian
Copy link
Member

Visiting for triage. Still a problem.

@steveklabnik
Copy link
Member

We still say move: http://doc.rust-lang.org/core/option/type.Option.html#method.unwrap

steveklabnik added a commit to steveklabnik/rust that referenced this issue Aug 18, 2014
@steveklabnik
Improve text of Option.unwrap()
46f27c9 
Fixes rust-lang#9099
@steveklabnik steveklabnik mentioned this issue Aug 18, 2014
Merged
bors added a commit that referenced this issue Aug 18, 2014
@bors
auto merge of #16579 : steveklabnik/rust/gh9099, r=pcwalton
fb4201f 
Fixes #9099
flip1995 pushed a commit to flip1995/rust that referenced this issue Jul 18, 2022
@bors
Auto merge of rust-lang#9099 - joshtriplett:unnecessary-lazy-eval-the…
f93d418 
…n-some, r=flip1995

Extend unnecessary_lazy_eval to cover `bool::then` -> `bool::then_some`

fixes rust-lang#9097

changelog: Extend `unnecessary_lazy_eval` to convert `bool::then` to `bool::then_some`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve text of Option.unwrap() steveklabnik/rust
5 participants
@steveklabnik @metajack @nikomatsakis @catamorphism @emberian