Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Show type layout for type aliases #91265

Closed
camelid opened this issue Nov 26, 2021 · 0 comments · Fixed by #91682
Closed

rustdoc: Show type layout for type aliases #91265

camelid opened this issue Nov 26, 2021 · 0 comments · Fixed by #91682
Assignees
@camelid
Labels
A-rustdoc-type-layout Area: `rustdoc --show-type-layout` (nightly-only) C-feature-request Category: A feature request, i.e: not implemented / a PR. requires-nightly This issue requires a nightly compiler in some way. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@camelid
Copy link
Member

camelid commented Nov 26, 2021 •
edited
Loading

Blocked on #85103. No longer blocked!
@camelid camelid added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-feature-request Category: A feature request, i.e: not implemented / a PR. requires-nightly This issue requires a nightly compiler in some way. A-rustdoc-type-layout Area: `rustdoc --show-type-layout` (nightly-only) S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Nov 26, 2021
@camelid camelid self-assigned this Dec 1, 2021
@camelid camelid mentioned this issue Dec 9, 2021
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 9, 2021
@matthiaskrgr
Rollup merge of rust-lang#91682 - camelid:alias-layout, r=jyn514
1eac9b7 
rustdoc: Show type layout for type aliases

Fixes rust-lang#91265.

At first, you might think, "Why not just click through to the aliased
type?" But, if a type alias instantiates all of the generic parameters
of the aliased type, then it can show layout info even though the
aliased type cannot (because we can't compute layout for generic types).
So, I think it's useful to show layout info for type aliases.

This is a followup of 78d4b453ad2e19d44011b26fc55c949bff5dba3d
(originally part of rust-lang#83501).
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 10, 2021
@matthiaskrgr
Rollup merge of rust-lang#91682 - camelid:alias-layout, r=jyn514
de3d1cc 
rustdoc: Show type layout for type aliases

Fixes rust-lang#91265.

At first, you might think, "Why not just click through to the aliased
type?" But, if a type alias instantiates all of the generic parameters
of the aliased type, then it can show layout info even though the
aliased type cannot (because we can't compute layout for generic types).
So, I think it's useful to show layout info for type aliases.

This is a followup of 78d4b453ad2e19d44011b26fc55c949bff5dba3d
(originally part of rust-lang#83501).
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 11, 2021
@matthiaskrgr
Rollup merge of rust-lang#91682 - camelid:alias-layout, r=jyn514
74f225b 
rustdoc: Show type layout for type aliases

Fixes rust-lang#91265.

At first, you might think, "Why not just click through to the aliased
type?" But, if a type alias instantiates all of the generic parameters
of the aliased type, then it can show layout info even though the
aliased type cannot (because we can't compute layout for generic types).
So, I think it's useful to show layout info for type aliases.

This is a followup of 78d4b453ad2e19d44011b26fc55c949bff5dba3d
(originally part of rust-lang#83501).
@bors bors closed this as completed in 33ebf4d Dec 11, 2021
@tgross35 tgross35 mentioned this issue Jul 1, 2023
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camelid camelid

Labels
A-rustdoc-type-layout Area: `rustdoc --show-type-layout` (nightly-only) C-feature-request Category: A feature request, i.e: not implemented / a PR. requires-nightly This issue requires a nightly compiler in some way. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc: Show type layout for type aliases camelid/rust
1 participant
@camelid