Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: extra semicolon #91874

Closed
Mark-Simulacrum opened this issue Dec 13, 2021 · 4 comments
Closed

regression: extra semicolon #91874

Mark-Simulacrum opened this issue Dec 13, 2021 · 4 comments
Labels
A-doctests Area: Documentation tests, run by rustdoc regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Milestone

Comments

@Mark-Simulacrum Mark-Simulacrum added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc labels Dec 13, 2021
@Mark-Simulacrum Mark-Simulacrum added this to the 1.58.0 milestone Dec 13, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Dec 13, 2021
@Mark-Simulacrum
Copy link
Member Author

Looks like previously reported in #91398, but not yet tracked as a regression.

@jyn514
Copy link
Member

jyn514 commented Dec 13, 2021

I still stand by #91398 (comment), I don't think this is a bug, just expected breakage from fixing a pre-existing bug.

@Mark-Simulacrum
Copy link
Member Author

Just because it's expected breakage / used to be a bug doesn't necessarily mean that we should be breaking stable users. In this case the breakage seems sufficiently limited that this is likely acceptable, but in general we should try to be more careful about landing breakage like this, though it's good to see that the PR was tagged as relnotes.

@jyn514 jyn514 added A-doctests Area: Documentation tests, run by rustdoc and removed E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc labels Dec 14, 2021
@pietroalbini
Copy link
Member

This is mentioned in the compatibility notes, closing.

@rustbot rustbot removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-doctests Area: Documentation tests, run by rustdoc regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants