Skip to content

With --rust-path-hack, rustpkg is too enthusiastic about matching directories #9273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
catamorphism opened this issue Sep 18, 2013 · 0 comments
Closed

With --rust-path-hack, rustpkg is too enthusiastic about matching directories #9273

catamorphism opened this issue Sep 18, 2013 · 0 comments

Comments

@catamorphism
Copy link
Contributor

With the flag, rustpkg will assume that the first directory that has any crate files in it matches any package it's searching for, and then build the contents and give it a name reflecting the package ID you wanted to build rather than the package ID that the sources are for. With perplexing results.

/cc @metajack
@ghost ghost assigned catamorphism Sep 18, 2013
@catamorphism catamorphism removed their assignment Jun 16, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue Aug 11, 2022
@bors
Auto merge of rust-lang#9273 - tabokie:assert_ok_fp, r=flip1995
a5a6c95 
Move [`assertions_on_result_states`] to restriction

Close rust-lang#9263

This lint causes regression on readability of code and log output. And printing runtime values is not particularly useful for majority of tests which should be reproducible.

changelog: Move [`assertions_on_result_states`] to restriction and don't lint it for unit type

Signed-off-by: tabokie <xy.tao@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@catamorphism