Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: stability and portability "pills" are sometimes broken to the next line #93177

Open
euclio opened this issue Jan 21, 2022 · 1 comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@euclio
Copy link
Contributor

euclio commented Jan 21, 2022

Screenshot demonstrating the issue:

Screen Shot 2022-01-21 at 12 50 45 PM

See https://doc.rust-lang.org/nightly/std/intrinsics/index.html for more examples.

I would expect these pills to stay on the same line as the item name except in the case of very long function names.

Meta

rustc --version --verbose:

rustc 1.58.1 (db9d1b20b 2022-01-20)
binary: rustc
commit-hash: db9d1b20bba1968c1ec1fc49616d4742c1725b4b
commit-date: 2022-01-20
host: x86_64-apple-darwin
release: 1.58.1
LLVM version: 13.0.0
@euclio euclio added the C-bug Category: This is a bug. label Jan 21, 2022
@camelid camelid added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jan 25, 2022
@jsha
Copy link
Contributor

jsha commented Jan 30, 2022

This was referenced somewhat in #85651 (comment) - @dns2utf8 @GuillaumeGomez.

In retrospect, I think the stability pill should be moved back to be part of the description text. That would avoid this ugly wrapping, and would align groups of stability pills with each other (on desktop), at the small cost of putting the stability pill on the next line on mobile (which I think is fine).

@GuillaumeGomez GuillaumeGomez added the A-rustdoc-ui Area: Rustdoc UI (generated HTML) label Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants