Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad span on obsolete syntax error #9348

Closed
jdm opened this issue Sep 19, 2013 · 0 comments
Closed

Bad span on obsolete syntax error #9348

jdm opened this issue Sep 19, 2013 · 0 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints

Comments

@jdm
Copy link
Contributor

jdm commented Sep 19, 2013 

/home/jdm/sdb/servo/src/components/script/dom/bindings/callback.rs:27:39: 27:40 error: obsolete syntax: visibility not necessary
/home/jdm/sdb/servo/src/components/script/dom/bindings/callback.rs:27     pub fn callback(&self) -> *JSObject;
                                                                                                             ^

It should be highlighting the pub instead.
@bors bors closed this as completed in fc44a9c Sep 27, 2013
Jarcho pushed a commit to Jarcho/rust that referenced this issue Aug 29, 2022
@bors
Auto merge of rust-lang#9348 - lukaslueg:issue9347, r=Alexendoo
eeaaba3 
Don't lint on match pattern-binding in ´question_mark`

Fixes rust-lang#9347

Technically it is possible to have a blank match-pattern that does nothing, and we fail to lint. But it's easier to be safe than sorry here.

changelog: [`question_mark`]: don't lint `if let`s with subpatterns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdm