-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking Issue for process_set_process_group #93857
Comments
…shtriplett Add a `process_group` method to UNIX `CommandExt` - Tracking issue: rust-lang#93857 - RFC: rust-lang/rfcs#3228 Add a `process_group` method to `std::os::unix::process::CommandExt` that allows setting the process group id (i.e. calling `setpgid`) in the child, thus enabling users to set process groups while leveraging the `posix_spawn` fast path.
…shtriplett Add a `process_group` method to UNIX `CommandExt` - Tracking issue: rust-lang#93857 - RFC: rust-lang/rfcs#3228 Add a `process_group` method to `std::os::unix::process::CommandExt` that allows setting the process group id (i.e. calling `setpgid`) in the child, thus enabling users to set process groups while leveraging the `posix_spawn` fast path.
…olnay Add a `process_group` method to UNIX `CommandExt` - Tracking issue: rust-lang#93857 - RFC: rust-lang/rfcs#3228 Add a `process_group` method to `std::os::unix::process::CommandExt` that allows setting the process group id (i.e. calling `setpgid`) in the child, thus enabling users to set process groups while leveraging the `posix_spawn` fast path.
…olnay Add a `process_group` method to UNIX `CommandExt` - Tracking issue: rust-lang#93857 - RFC: rust-lang/rfcs#3228 Add a `process_group` method to `std::os::unix::process::CommandExt` that allows setting the process group id (i.e. calling `setpgid`) in the child, thus enabling users to set process groups while leveraging the `posix_spawn` fast path.
This may or may not need a Fuchsia implementation. See #93858 (comment). @rustbot ping fuchsia |
Hey friends of Fuchsia! This issue could use some guidance on how this should be cc @tmandry |
…olnay Add a `process_group` method to UNIX `CommandExt` - Tracking issue: rust-lang#93857 - RFC: rust-lang/rfcs#3228 Add a `process_group` method to `std::os::unix::process::CommandExt` that allows setting the process group id (i.e. calling `setpgid`) in the child, thus enabling users to set process groups while leveraging the `posix_spawn` fast path.
Some updates:
|
T-libs-api, shall we stabilize @rfcbot merge |
Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
This LGTM, but can we improve the docs for
|
👍
Some suggested documentation: "Process groups determine which processes receive a signal when the user kills a process from its controlling terminal (e.g. hitting Ctrl-C to generate SIGTERM or Ctrl-\ to generate SIGQUIT). Shells and other programs that launch other programs use process groups to partition launched programs, such as foreground and background processes."
As well as being safe, instead of the |
Fuchsia does have a concept of jobs which have the same or similar role as process groups, but doesn't implement the POSIX notion of a process group id that's a universal integer. Instead, jobs (like all kernel objects) are represented by random 32-bit handles that are issued to a process by the kernel. It might be possible to shoehorn this into the POSIX interface by passing a handle as a |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
Tracking issue: rust-lang#93857 FCP finished here: rust-lang#93857 (comment)
…ss_group, r=joshtriplett Document and stabilize process_set_process_group Tracking issue: rust-lang#93857 FCP finished here: rust-lang#93857 (comment)
Stabilized by #99088, closing. |
Tracking issue: rust-lang/rust#93857 FCP finished here: rust-lang/rust#93857 (comment)
… r=joshtriplett Document and stabilize process_set_process_group Tracking issue: rust-lang/rust#93857 FCP finished here: rust-lang/rust#93857 (comment)
Building on v1.63 fails with: ``` error[E0658]: use of unstable library feature 'process_set_process_group' --> ~/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.29.0/src/process/mod.rs:777:18 | 777 | self.std.process_group(pgroup); | ^^^^^^^^^^^^^ | = note: see issue #93857 <rust-lang/rust#93857> for more information ```
Feature gate:
#![feature(process_set_process_group)]
This is a tracking issue for: Add a
process_group
method to UNIXCommandExt
Add a
process_group
method tostd::os::unix::process::CommandExt
thatallows setting the process group id (i.e. calling
setpgid
) in the child, thusenabling users to set process groups while leveraging the
posix_spawn
fastpath.
Public API
Steps / History
process_group
method to UNIXCommandExt
rfcs#3228process_group
method to UNIXCommandExt
#93858Unresolved Questions
The text was updated successfully, but these errors were encountered: