Explain name of rustc_middle::traits::query::DtorckConstraint

[pierwill]

What does Dtorck in DtorckConstraint stand for? "Destruction check?" Didn't find any answer in a few searches of docs and rustc dev guide.

@rustbot label:T-compiler E-easy

[b-ncMN]

@rustbot claim

[b-ncMN]

After a bit of goofing around in the code, I think that Dtor stands for Destructor, so it would be DestructorCheckConstraint, probably

[bjorn3]

I believe other parts of the code refer to it as dropck (drop check) rather than destructor check.

[b-ncMN]

Drop"top"check?
What would the "top" be for then?
Besides, I think Drop makes more sense to Destructor, but in this context, I think destructor makes more sense? ig?

[bjorn3]

It may be that DtorckConstraint was named before we consistently starting to use dropck.

[b-ncMN]

So should this be renamed altogether if that's the case ?
To a name like DropCkConstraint, perhaps?
Well actually, I don't think that's the case because, in 4e42f388, which created that file in the first place, DropCk already appears to be a thing?
So maybe this instance wasn't renamed when dropck started to get used?

[bjorn3]

I think so.

[b-ncMN]

Edited.

[bjorn3]

DtorckConstraint was moved in that commit. You can see that it originated from here: 4e42f388#diff-d2a1fdabeaebb273459e840ceb8ad8eef3e2dd5f8b34b608309587217608216bL104

[b-ncMN]

DtorckConstraint was moved in that commit. You can see that it originated from here: 4e42f388#diff-d2a1fdabeaebb273459e840ceb8ad8eef3e2dd5f8b34b608309587217608216bL104

Right, yeah I meant it was moved.
Renaming it is then.