-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap DtorckConstraint to DropckConstraint #95280
Swap DtorckConstraint to DropckConstraint #95280
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon. Please see the contribution instructions for more information. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This change was made as per suspicion that this struct was never renamed after consistent use of DropCk. This also clarifies the meaning behind the name of this structure.
@bors try |
@InfRandomness: 🔑 Insufficient privileges: not in try users |
How do I manually launch a workflow on this? |
CI is broken right now. Or do you need a try build for something specific? |
You can run |
I've wanted to confirm the formatting is correct, I tested it locally and pushed it but it didn't kick a new pipeline,
locally, everything seems fine
also looks fine locally |
@bors try |
Bors didn't respond |
@bors r+ rollup Thanks! |
📌 Commit 645620b has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (09be68c): comparison url. Summary: This benchmark run did not return any relevant results. 2 results were found to be statistically significant but too small to be relevant. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This change was made as per suspicion that this struct was never renamed after consistent use of DropCk.
This also clarifies the meaning behind the name of this structure.
Fixes #94310