Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap DtorckConstraint to DropckConstraint #95280

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Swap DtorckConstraint to DropckConstraint #95280

merged 1 commit into from
Mar 25, 2022

Conversation

b-ncMN
Copy link
Contributor

@b-ncMN b-ncMN commented Mar 24, 2022

This change was made as per suspicion that this struct was never renamed after consistent use of DropCk.

This also clarifies the meaning behind the name of this structure.

Fixes #94310

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 24, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 24, 2022
@b-ncMN b-ncMN marked this pull request as draft March 24, 2022 18:29
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

This change was made as per suspicion that this struct was never renamed after consistent use of DropCk.

This also clarifies the meaning behind the name of this structure.
@b-ncMN b-ncMN marked this pull request as ready for review March 24, 2022 20:00
@b-ncMN
Copy link
Contributor Author

b-ncMN commented Mar 24, 2022

@bors try

@bors
Copy link
Contributor

bors commented Mar 24, 2022

@InfRandomness: 🔑 Insufficient privileges: not in try users

@b-ncMN
Copy link
Contributor Author

b-ncMN commented Mar 24, 2022

How do I manually launch a workflow on this?

@oli-obk
Copy link
Contributor

oli-obk commented Mar 24, 2022

CI is broken right now. Or do you need a try build for something specific?

@oli-obk
Copy link
Contributor

oli-obk commented Mar 24, 2022

You can run ./x.py check locally to quickly see if everything at least compiles

@b-ncMN
Copy link
Contributor Author

b-ncMN commented Mar 24, 2022

CI is broken right now. Or do you need a try build for something specific?

I've wanted to confirm the formatting is correct, I tested it locally and pushed it but it didn't kick a new pipeline,
I've ran

./x.py test tidy --bless

locally, everything seems fine

./x.py check

also looks fine locally

@Dylan-DPC
Copy link
Member

@bors try

@b-ncMN
Copy link
Contributor Author

b-ncMN commented Mar 25, 2022

Bors didn't respond

@lcnr lcnr closed this Mar 25, 2022
@lcnr lcnr reopened this Mar 25, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Mar 25, 2022

@bors r+ rollup

Thanks!

@bors
Copy link
Contributor

bors commented Mar 25, 2022

📌 Commit 645620b has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2022
@bors
Copy link
Contributor

bors commented Mar 25, 2022

⌛ Testing commit 645620b with merge 09be68c...

@bors
Copy link
Contributor

bors commented Mar 25, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 09be68c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 25, 2022
@bors bors merged commit 09be68c into rust-lang:master Mar 25, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 25, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (09be68c): comparison url.

Summary: This benchmark run did not return any relevant results. 2 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain name of rustc_middle::traits::query::DtorckConstraint
9 participants