Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and update docs for rustc_infer::infer::lattice #94311

Closed
pierwill opened this issue Feb 24, 2022 · 2 comments · Fixed by #94312
Closed

Review and update docs for rustc_infer::infer::lattice #94311

pierwill opened this issue Feb 24, 2022 · 2 comments · Fixed by #94312
Assignees
@pierwill

Comments

@pierwill
Copy link
Member

pierwill commented Feb 24, 2022 •
edited by rustbot
Loading

The docs for rustc_infer::infer::lattice (source here) refer to a file called infer.rs.

Currently, we only have two files with that name:

  • ./compiler/rustc_trait_selection/src/infer.rs
  • ./compiler/rustc_typeck/src/outlives/implicit_infer.rs

Where is thelattice code referred to here?

Perhaps we should describe the implementation here more instead of just linking to file.
@pierwill
Copy link
Member Author

@rustbot claim

@pierwill
Copy link
Member Author

pierwill commented Feb 24, 2022 •
edited
Loading

@pierwill pierwill mentioned this issue Feb 24, 2022
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Mar 9, 2022
@Dylan-DPC
Rollup merge of rust-lang#94312 - pierwill:fix-94311-lattice-docs, r=…
d6f92cd 
…jackh726

Edit `rustc_trait_selection::infer::lattice` docs

Closes rust-lang#94311.

Removes mentions of outdated/missing type and filename (`infer.rs` and `LatticeValue`).
@bors bors closed this as completed in 2b17c27 Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pierwill pierwill

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Edit rustc_trait_selection::infer::lattice docs pierwill/rust
1 participant
@pierwill