-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustpkg: error downloading external dependencies. #9482
Comments
@cmr also reported: https://gist.github.com/cmr/7a3d37572e6ea586831e |
@catamorphism I just spent a bit of time digging into this after noticing that this problem affected me everywhere except in subdirectories of /tmp. The problem is the os::rename_file here: https://github.com/mozilla/rust/blob/master/src/librustpkg/package_source.rs#L205 It's calling libc::rename, which is returning -1 and throwing errno 18, cross-device link. So it looks like rustpkg will have to copy and delete instead of rename()ing if using /tmp, or maybe just clone into .rust/src directly. Eridius suggested this in #rust: "perhaps there should be a dir in .rust that it clones in to, e.g. |
I think @thewonderidiot 's hypothesis is likely to be correct, but I have yet to be able to actually reproduce this myself on a Linux machine :-\ Also see: #9871 |
@catamorphism I am currently working on adding support for mercurial to rustpkg. Here. Will also look into this issue. |
Closing as dup of #10253 |
[`drop_ref`]: don't lint idiomatic in match arm fixes rust-lang#10122 As established in issue rust-lang#9482, it is idiomatic to use a single `drop()` expression in a match arm to achieve a side-effect of a function while discarding its output. This should also apply to cases where the function returns a reference. The change to the lint's code was less than 1 line, because all the heavy lifting was done in PR rust-lang#9491. --- changelog: FP: [`drop_ref`]: No longer lints idiomatic expression in `match` arms [rust-lang#10142](rust-lang/rust-clippy#10142) <!-- changelog_checked -->
The text was updated successfully, but these errors were encountered: