Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark doesn't handle code taking >1ms #9532

Closed
lilyball opened this issue Sep 26, 2013 · 0 comments · Fixed by #10952
Closed

Benchmark doesn't handle code taking >1ms #9532

lilyball opened this issue Sep 26, 2013 · 0 comments · Fixed by #10952

Comments

@lilyball
Copy link
Contributor

From reading the extra::test::auto_bench() code, there's no handling in here for when one iteration takes >1ms to run. If I understand this correctly, that will cause the code to decide to run for 0 iterations, and it will then proceed to try and run the 0-iteration benchmarks over and over until it hits the 3 second timeout and bails.
@bluss bluss mentioned this issue Oct 2, 2013
Closed
@huonw huonw mentioned this issue Dec 13, 2013
Merged
@eddyb eddyb mentioned this issue Dec 13, 2013
Merged
bors added a commit that referenced this issue Dec 14, 2013
@bors
auto merge of #10952 : huonw/rust/1ms-bench, r=cmr
ca54ad8 
This makes sure we always run benchmarks even if they are predicted to
take a long time, so that we have some non-zero time to display
(although the error bars may be huge for particularly slow benchmarks).

Fixes #9532.
@huonw huonw closed this as completed in 79739d9 Dec 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

extra::test: handle slow benchmarks more gracefully. huonw/rust
1 participant
@lilyball