Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf regression on rustdoc --document-private-items speed #95694

Closed
GuillaumeGomez opened this issue Apr 5, 2022 · 2 comments
Closed

Perf regression on rustdoc --document-private-items speed #95694

GuillaumeGomez opened this issue Apr 5, 2022 · 2 comments
Assignees
@petrochenkov
Labels
regression-untriaged Untriaged performance or correctness regression. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

The regression was introduced in #95645. It seems that we're trying to get too many items.

cc @petrochenkov
@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. regression-untriaged Untriaged performance or correctness regression. labels Apr 5, 2022
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Apr 5, 2022
@GuillaumeGomez GuillaumeGomez mentioned this issue Apr 5, 2022
Merged
@petrochenkov petrochenkov self-assigned this Apr 5, 2022
@petrochenkov petrochenkov mentioned this issue Apr 5, 2022
Merged
@petrochenkov
Copy link
Contributor

Should be fixed in #95706.

bors added a commit to rust-lang-ci/rust that referenced this issue Apr 7, 2022
@bors
Auto merge of rust-lang#95706 - petrochenkov:doclink4, r=GuillaumeGomez
dd38eea 
rustdoc: Early doc link resolution fixes and refactorings

A subset of rust-lang#94857 that shouldn't cause perf regressions, but should fix some issues like https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/ICE.20in.20collect_intra_doc_links.2Ers rust-lang#95290 and improve performance in cases like rust-lang#95694.
@GuillaumeGomez
Copy link
Member Author

It was fixed in #95706.

@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petrochenkov petrochenkov

Labels
regression-untriaged Untriaged performance or correctness regression. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@GuillaumeGomez @petrochenkov @apiraino @rustbot