When we switch to opaque pointers, stop identifying ADTs in LLVM IR (with fewer_names
)
#96242
Labels
A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
This is an extension of #94107. It may be a minor perf win.
Basically, when we switch to using opaque pointers, this comment will no longer be true:
rust/compiler/rustc_codegen_llvm/src/type_of.rs
Lines 67 to 69 in 27af517
@rustbot label A-llvm T-compiler S-blocked
Edit: the simplest implementation, e.g. changing those lines to
doesn't work because then we end up infinitely recursing into the pointee type in order to generate a literal struct type. (Removing pointee types from the codegen backend would avoid this, which I am working on.)
The text was updated successfully, but these errors were encountered: