Make rustpkg accept multiple package IDs in a single command #9649
Comments
|
rustpkg is gone |
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Oct 20, 2022
…=llogiq Add a suggestion and a note about orphan rules for `from_over_into` Adds a machine applicable suggestion to convert the `Into` impl into a `From` one to `from_over_into` Also adds a note explaining that `impl From<Local> for Foreign` is fine if the `Into` type is foreign Closes rust-lang#7444 Addresses half of rust-lang#9638 changelog: [`from_over_into`] Add a suggestion and a note about orphan rules
lnicola
pushed a commit
to lnicola/rust
that referenced
this issue
Sep 25, 2024
…rsky internal: Add preliminary `SyntaxEditor` functionality Related to rust-lang#15710 Implements a `SyntaxEditor` interface to abstract over the details of modifying syntax trees, to both simplify creating new code fixes and code actions, as well as start on the path of getting rid of mutable syntax nodes. `SyntaxEditor` relies on `SyntaxMappingBuilder`s to feed in the correct information to map AST nodes created by `make` constructors, as `make` constructors do not guarantee that node identity is preserved. This is to paper over the fact that `make` constructors simply re-parse text input instead of building AST nodes from the ground up and re-using the provided syntax nodes. `SyntaxAnnotation`s are used to find where syntax elements have ended up after edits are applied. This is primarily useful for the `add_{placeholder,tabstop}` set of methods on `SourceChangeBuilder`, as that currently relies on the nodes provided being in the final syntax tree. Eventually, the goal should be to move this into the `rowan` crate when we move away from mutable syntax nodes, but for now it'll stay in the `syntax` crate. --- Closes rust-lang#14921 as `SyntaxEditor` ensures that all replace changes are disjoint Closes rust-lang#9649 by implementing `SyntaxAnnotation`s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rustpkg should be able to accept more than one package ID in a single command. The reason to do this is that multiple parallel rustpkg processes will have unpredictable results, because rustpkg currently doesn't lock the workcache database file in any way. To get around this, we should allow rustpkg to accept multiple package IDs (it will then build them in parallel). We should also document that it's a bad idea to run multiple rustpkg instances in parallel, but I'll make another issue for that.
The text was updated successfully, but these errors were encountered: