Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf regression caused by initial support of RFC 3191 #96786

Closed
ridwanabdillahi opened this issue May 6, 2022 · 1 comment
Closed

Perf regression caused by initial support of RFC 3191 #96786

ridwanabdillahi opened this issue May 6, 2022 · 1 comment
Assignees

Comments

@ridwanabdillahi
Copy link
Contributor

ridwanabdillahi commented May 6, 2022

Spawned off of #91779 (comment) . The perf run shows a noticeable regression after the initial round of changes to implement RFC 3191.

This issue is meant to track resolving the perf regression, so it doesn't get lost in the noise.

@rustbot claim

@ridwanabdillahi
Copy link
Contributor Author

I ran a variety of experiments to improve the perf regression, but it seems this was caused by the overall overhead of adding a new feature which not only added new symbols but also added fields to the CrateMetadata object. This causes more data to be serialized and deserialized for every crate even if the items are blank. The performance analysis showed that the majority of scenarios causing the regression were the incr-unchanged scenario which is what I would expect from additional metadata reads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant