-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mingw: panic when compiling rustc_llvm #97299
Comments
Note that we have |
Yes, the ICE is caused by Even without ICE you'll need a workaround for the error that it's masking - linking the library with modifiers either only from command line, or only from |
The ICE is a regression from #93901. |
Fixed in #97328. |
Fixes a number of issues in compiler/rustc_llvm regarding lib handling. This is a moving part in current rust releases... - Disabled llvm-static-stdcpp Fixes CLANG64 build error: thread 'main' panicked at 'assertion failed: !cxxflags.contains(\"stdlib=libc++\")', compiler\rustc_llvm\build.rs:351:13 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace - Removed `pthread` from forced libs in compiler/rustc_llvm/build.rs `pthread` is also provided by llvm-config and having both now triggers an error about mixed link modifiers. See rust-lang/rust#97299 $ llvm-config --system-libs --link-static -lpsapi -lshell32 -lole32 -luuid -ladvapi32 -lpthread -lz -lxml2 Note that `ffi` is still forced by the patch as llvm-config does not provide it. See 0001-rustc-llvm-fix-libs.patch (replaces 0001-add-missing-libs.patch). - Rebased 0007-clang-subsystem.patch quick and dirty test
Fixes a number of issues in compiler/rustc_llvm regarding lib handling. This is a moving part in current rust releases... - Disabled llvm-static-stdcpp Fixes CLANG64 build error: thread 'main' panicked at 'assertion failed: !cxxflags.contains(\"stdlib=libc++\")', compiler\rustc_llvm\build.rs:351:13 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace - Removed `pthread` from forced libs in compiler/rustc_llvm/build.rs `pthread` is also provided by llvm-config and having both now triggers an error about mixed link modifiers. See rust-lang/rust#97299 $ llvm-config --system-libs --link-static -lpsapi -lshell32 -lole32 -luuid -ladvapi32 -lpthread -lz -lxml2 Note that `ffi` is still forced by the patch as llvm-config does not provide it. See 0001-rustc-llvm-fix-libs.patch (replaces 0001-add-missing-libs.patch). - Rebased 0007-clang-subsystem.patch
…rister rustc: Fix ICE in native library error reporting Fixes rust-lang#97299
Code
There is no code.
The internal compiler error happens when building rustc itself (on MSYS2/Mingw)
Meta
We are trying to build Rust 1.61.0.
The error happens when building
rustc_llvm
while processing the libs passed on therustc
command line.The issue concerns native library modifiers and was most probably introduced by 1004783.
The line that triggers the panic is here: https://github.com/rust-lang/rust/blob/1.61.0/compiler/rustc_metadata/src/native_libs.rs#L384
The code change in question broke the handling of
-bundle
(i.e. no bundle) which is used when building on mingw.See here for an example: https://github.com/rust-lang/rust/blob/1.61.0/compiler/rustc_llvm/build.rs#L369
Error output
Backtrace
The text was updated successfully, but these errors were encountered: