Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustpkg creates temporary directories but does not delete them #9764

Closed
ben0x539 opened this issue Oct 8, 2013 · 1 comment · Fixed by #9802
Closed

rustpkg creates temporary directories but does not delete them #9764

ben0x539 opened this issue Oct 8, 2013 · 1 comment · Fixed by #9802

Comments

@ben0x539
Copy link
Contributor

ben0x539 commented Oct 8, 2013

rustpkg calls extra::tempfile::mkdtemp (mostly in rustpkg/tests but also in rustpkg::{package_source,version}) and doesn't ever remove the resulting directories.

/tmp grows by 8MiB every time I run make check, we should fix it before I run out of disk space and have to reboot! ;)
@ben0x539
Copy link
Contributor Author

ben0x539 commented Oct 8, 2013

I was looking into fixing this myself (eg. like this) but I decided I want to see if there's interest in changing mkdtemp to return an RAII wrapper so I don't have to do the RAII in rustpkg code (#9763). But I also don't want to forget about this!

@ben0x539 ben0x539 mentioned this issue Oct 10, 2013
Merged
@bors bors closed this as completed in 93a08f4 Oct 11, 2013
@hatahet hatahet mentioned this issue Oct 24, 2013
Closed
flip1995 pushed a commit to flip1995/rust that referenced this issue Jun 27, 2024
@bors
Auto merge of rust-lang#10398 - Alexendoo:auto-lintcheck, r=xFrednet
a2c9782 
Run a diff of lintcheck against the merge base for pull requests

changelog: none
<!-- changelog_checked -->

This is an MVP of sorts, it consists of rust-lang#9764 + a GitHub action that feeds the output to the [job summary](https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#adding-a-job-summary). It doesn't yet do anything fancy like `--recursive` or adding comments to the PR, so you'd have to click through to the action to see the results

Example output of a change (Alexendoo/rust-clippy@0be1ab8): https://github.com/Alexendoo/rust-clippy/actions/runs/4264858870#summary-11583333018

r? `@flip1995`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

extra::tempfile: replace mkdtemp with an RAII wrapper (Closes #9763) ben0x539/rust
1 participant
@ben0x539