Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for --extern nounused #98400

Open
1 of 4 tasks
ehuss opened this issue Jun 22, 2022 · 5 comments
Open
1 of 4 tasks

Tracking issue for --extern nounused #98400

ehuss opened this issue Jun 22, 2022 · 5 comments
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC

Comments

@ehuss
Copy link
Contributor

ehuss commented Jun 22, 2022

This is a tracking issue for the nounused CLI option for --extern.

This option marks the given crate so that it does not trigger unused_crate_dependencies warnings for the crate.

This is useful if the given crate might be unused, but shouldn't cause a warning.
For example, when using --extern to link with standard library crates, and the user does not explicitly use one of those crates.

The syntax is [opts ':'] name ['=' path] where opts is a comma separated list of options:

--extern nounused:foo=/path/to/libfoo.rlib

See also #98398 and #98399 which share this syntax extension.

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

  • The syntax for adding options to --extern flags was added without much bikeshedding or discussion. It may need adjusting to be more flexible for more complex options.

Implementation history

@ehuss ehuss added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Jun 22, 2022
@petrochenkov
Copy link
Contributor

Stabilization blocked on "Tracking Issue --extern crate modifiers".

@est31
Copy link
Member

est31 commented Jun 24, 2022

I think the name is a bit hard to read. What about no_unused or allow_unused?

@jsgf
Copy link
Contributor

jsgf commented Jun 25, 2022

I don't care particularly, but it should be consistent with noprelude.

Since these aren't at all user-facing, I'm not too concerned about readability so long as they make sense to someone who does have to deal with them.

@est31
Copy link
Member

est31 commented Jun 25, 2022

I see, the noprelude argument convinced me.

@ehuss
Copy link
Contributor Author

ehuss commented Jun 25, 2022

#98405 is proposing to possibly use +/- syntax like -prelude or +priv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC
Projects
None yet
Development

No branches or pull requests

4 participants