Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: CodeMirror should ignore 'static/'self #9873

Closed
adrientetar opened this issue Oct 15, 2013 · 2 comments · Fixed by #12783
Closed

doc: CodeMirror should ignore 'static/'self #9873

adrientetar opened this issue Oct 15, 2013 · 2 comments · Fixed by #12783

Comments

@adrientetar
Copy link
Contributor

CodeMirror JS syntax highlight currently trys to parse 'static or 'self blocks as string, and fails with a red error highlight because it doesn't find the end '.
We need to configure CodeMirror to ignore syntaxhighlight when it encounters these keywords.
See here: http://static.rust-lang.org/doc/0.8/rust.html#static-items

cc @marijnh
@adrientetar
Copy link
Contributor Author

For reference, a cheap fix that didn't work: adrientetar@ded910f#diff-0

@marijnh
Copy link
Contributor

marijnh commented Oct 16, 2013

The CodeMirror Rust mode is waaaay old and hasn't been updated in ages. I unfortunately don't have time for a rewrite right now (mostly because that'd first require familiarizing myself with modern Rust syntax, which'd take some time), but if someone decides to work on this, feel free to ask questions here, I'll try to answer.

@adrientetar adrientetar mentioned this issue Nov 11, 2013
Merged
adrientetar added a commit to adrientetar/rust that referenced this issue Nov 13, 2013
@adrientetar
doc: disable parser error highlighting + a few fixes
5a01dbe 
CodeMirror parser errors are related to rust-lang#9873.
bors added a commit that referenced this issue Nov 13, 2013
@bors
auto merge of #10421 : adridu59/rust/patch-www, r=alexcrichton
49c6ae1 
* Closes #10330
* Improves on #9873
* Adds favicon for tutorial files
@adrientetar adrientetar mentioned this issue Mar 9, 2014
Merged
@bors bors closed this as completed in 74bfa71 Mar 11, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue Nov 21, 2022
@bors
Auto merge of rust-lang#9873 - smoelius:move-line-span, r=flip1995
51ec465 
Move `line_span` to source.rs

`line_span` is a non-public function used only in source.rs. It seems like it ought to go in source.rs.

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: cleanups adrientetar/rust
2 participants
@marijnh @adrientetar