Skip to content

rustpkg: Can't find libraries. #9948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dpc opened this issue Oct 19, 2013 · 7 comments
Closed

rustpkg: Can't find libraries. #9948

dpc opened this issue Oct 19, 2013 · 7 comments

Comments

@dpc
Copy link
Contributor

dpc commented Oct 19, 2013

I want to be able to use rustpkg to build current project like this:

[mutex:rust/test]% cat src/hellobin/main.rs
extern mod hello;

fn main() {
            hello::world();
}

[mutex:rust/test]% rustpkg install github.com/steveklabnik/hello
WARNING: The Rust package manager is experimental and may be unstable
(...)
note: Installed package github.com/steveklabnik/hello-0.1 to /home/dpc/lab/rust/test/.rust

[mutex:rust/test]% rustpkg build hellobin
WARNING: The Rust package manager is experimental and may be unstable
task <unnamed> failed at 'Unhandled condition: nonexistent_package: (package_id::PkgId{path: std::path::PosixPath{is_absolute: false, components: ~[~"hello"]}, short_name: ~"hello", version: NoVersion}, ~"supplied path for package dir does not exist, and couldn't interpret it as a URL fragment")', /home/dpc/opt/src/rust/src/libstd/condition.rs:131
task <unnamed> failed at 'receiving on closed channel', /home/dpc/opt/src/rust/src/libstd/rt/comm.rs:188

rustc version works as expected:

[mutex:rust/test]% rustc src/hellobin/main.rs
[mutex:rust/test]%

So, I'd expect rustpkg build hellobin to work as well and just trigger corresponding rustc command.

@dpc
Copy link
Contributor Author

dpc commented Oct 19, 2013

For the reference:

[mutex:rust/test]% rustc --version
rustc 0.8 (8a4f0fa 2013-09-25 19:50:56 -0700)
host: x86_64-unknown-linux-gnu

@catamorphism
Copy link
Contributor

In this case, you would have to write extern mod hello = "github.com/steveklabnik/hello";

@dpc
Copy link
Contributor Author

dpc commented Oct 19, 2013

@catamorphism: I did:

[mutex:rust/test]% vi src/hellobin/main.rs # add the change you describe
[mutex:rust/test]% rustpkg build hellobin                                                                                 master 
WARNING: The Rust package manager is experimental and may be unstable
task <unnamed> failed at 'assertion failed: os::path_exists(&pkg_src.start_dir.push_rel(p))', /home/dpc/opt/src/rust/src/librustpkg/rustpkg.rs:433

Probably different problem (the TMPDRI hack does not help neither).

I get your point however. The package id full url, not only the last part. Is that what you mean?

@catamorphism
Copy link
Contributor

It would be worth it to try updating rust, since I've fixed some significant bugs in rustpkg since 9/25. Sorry for the trouble.

@dpc
Copy link
Contributor Author

dpc commented Oct 19, 2013

Same problem on master branch.

@catamorphism
Copy link
Contributor

I will re-test this after I land my fix for #10253. (Haven't submitted the PR yet.)

@ghost ghost assigned catamorphism Nov 8, 2013
@sfackler
Copy link
Member

sfackler commented Feb 4, 2014

rustpkg doesn't exist anymore, closing

@sfackler sfackler closed this as completed Feb 4, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 6, 2023
This contains preparatory work for rust-lang#9948 to keep that change to the
minimum, and make it easier to review it.
flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 6, 2023
Partial no-op refactoring of rust-lang#9948

This contains some prep work for rust-lang#9948 to keep that change to the minimum, and make it easier to review it.

This should be a noop, but it has some tests from that PR discussion, and should help in the future with the corner case format handling.

cc: `@Alexendoo` `@llogiq` `@xFrednet`  as the 3 people who reviewed the parent PR

----

changelog: none
flip1995 pushed a commit to flip1995/rust that referenced this issue Nov 28, 2024
Add support for `#[clippy::format_args]` attribute that can be attached
to any macro to indicate that it functions the same as the built-in
format macros like `format!`, `println!` and `write!`

---

changelog: Enhancement: [`format_in_format_args`],
[`recursive_format_impl`], [`to_string_in_format_args`],
[`uninlined_format_args`], [`unused_format_specs`]: Recognizes
`#[clippy::format_args]` to support custom 3rs party format macros.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants