Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build rustdoc JSON for all crates with crater before stabilization #99919

Open
Enselic opened this issue Jul 29, 2022 · 17 comments
Open

Build rustdoc JSON for all crates with crater before stabilization #99919

Enselic opened this issue Jul 29, 2022 · 17 comments
Labels
A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Enselic
Copy link
Member

Enselic commented Jul 29, 2022

Before we stabilize rustdoc JSON, we should make sure that we can build rustdoc JSON for all crates on crates.io without ICEs or other errors.

This issue is meant to be used as a trigger point for crater runs.

See this Zulip topic for more info.

Support for building rustdoc JSON with crater was recently deployed.

@rustbot labels +A-rustdoc-json +T-rustdoc

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 29, 2022
@Enselic
Copy link
Member Author

Enselic commented Jul 29, 2022

First try: warming up with just one crate, and seeing if whitespace is properly escaped:

@craterbot run name=rustdoc-json-1 mode=rustdoc crates=list:serde cap-lints=allow start=nightly-2022-06-01+rustdocflags=-Zunstable-options\ -wjson end=nightly+rustdocflags=-Zunstable-options\ -wjson

@craterbot
Copy link
Collaborator

🔒 Error: you're not allowed to interact with this bot.

🔑 If you are a member of the Rust team and need access, add yourself to the whitelist.
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@GuillaumeGomez
Copy link
Member

Let's try.

@craterbot run name=rustdoc-json-1 mode=rustdoc crates=list:serde cap-lints=allow start=nightly-2022-06-01+rustdocflags=-Zunstable-options\ -wjson end=nightly+rustdocflags=-Zunstable-options\ -wjson

@craterbot
Copy link
Collaborator

👌 Experiment rustdoc-json-1 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jul 29, 2022
@craterbot
Copy link
Collaborator

🚧 Experiment rustdoc-json-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment rustdoc-json-1 is completed!
📊 0 regressed and 1 fixed (1 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Aug 8, 2022
@jyn514
Copy link
Member

jyn514 commented Aug 8, 2022

@craterbot run mode=rustdoc cap-lints=allow start=nightly end=nightly+rustdocflags=-Zunstable-options\ -wjson

@craterbot
Copy link
Collaborator

👌 Experiment pr-99919 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2022
@craterbot
Copy link
Collaborator

🚧 Experiment pr-99919 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-99919 is completed!
📊 8 regressed and 22 fixed (240769 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Nemo157
Copy link
Member

Nemo157 commented Aug 17, 2022

@craterbot run mode=rustdoc crates=list:bradleyharden/fft_iter_bench,hans-arn/SEC_2,stuartZhang/scaffold-wizard,belong,catboost2-sys,easy_proc,tzdb,vue-sfc cap-lints=allow start=nightly end=nightly+rustdocflags=-Zunstable-options\ -wjson

@craterbot
Copy link
Collaborator

👌 Experiment pr-99919-1 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2022
@craterbot
Copy link
Collaborator

🚧 Experiment pr-99919-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-99919-1 is completed!
📊 2 regressed and 0 fixed (8 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Aug 17, 2022
@jyn514
Copy link
Member

jyn514 commented Aug 17, 2022

Hmm weird, looks like we still have 8 root regressions?

@Enselic
Copy link
Member Author

Enselic commented Aug 17, 2022

@jyn514 Hmm which ones do you mean?

@jyn514
Copy link
Member

jyn514 commented Aug 17, 2022

Ugh, GitHub was being buggy and showing me #99919 (comment) as the latest comment. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants