Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Iterator::array_chunks (take N+1) #100026

Merged
merged 12 commits into from
Aug 14, 2022
Merged

Add Iterator::array_chunks (take N+1) #100026

merged 12 commits into from
Aug 14, 2022

Commits on Aug 1, 2022

  1. Add Iterator::array_chunks()

    @rossmacarthur @WaffleLapkin
    rossmacarthur authored and WaffleLapkin committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    ca3d101 View commit details
    Browse the repository at this point in the history

  2. Use array::IntoIter for the ArrayChunks remainder

    @rossmacarthur @WaffleLapkin
    rossmacarthur authored and WaffleLapkin committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    f548518 View commit details
    Browse the repository at this point in the history

  3. Remove array::IntoIter::with_partial -- an artifact of the past, on… 

    …ce used to create an `IntoIter` from its parts
    @WaffleLapkin
    WaffleLapkin committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    ef72349 View commit details
    Browse the repository at this point in the history

  4. Forward ArrayChunks::next{,_back} to try_{for_each,rfold} 

    (suggested in the review of the previous attempt to add `ArrayChunks`)
    @WaffleLapkin
    WaffleLapkin committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    b8b1486 View commit details
    Browse the repository at this point in the history

  5. Remove incorrect impl TrustedLen for ArrayChunks 

    As explained in the review of the previous attempt to add `ArrayChunks`,
adapters that shrink the length can't implement `TrustedLen`.
    @WaffleLapkin
    WaffleLapkin committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    4db628a View commit details
    Browse the repository at this point in the history

  6. Use #[track_caller] to make panic in Iterator::array_chunks nicer

    @WaffleLapkin
    WaffleLapkin committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    3102b39 View commit details
    Browse the repository at this point in the history

  7. Remove Fuse from ArrayChunks implementation 

    It doesn't seem to be used at all.
    @WaffleLapkin
    WaffleLapkin committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    37dfb04 View commit details
    Browse the repository at this point in the history

  8. Simplify ArrayChunks::is_empty

    @WaffleLapkin
    WaffleLapkin committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    4c0292c View commit details
    Browse the repository at this point in the history

  9. Simplify ArrayChunks::{,r}fold impls

    @WaffleLapkin
    WaffleLapkin committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    475e4ba View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2022

  1. Use next_chunk in ArrayChunks impl

    @WaffleLapkin
    WaffleLapkin committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    756bd6e View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. address review comments

    @WaffleLapkin
    WaffleLapkin committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    eb6b729 View commit details
    Browse the repository at this point in the history

  2. fill-in tracking issue for feature(iter_array_chunks)

    @WaffleLapkin
    WaffleLapkin committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    5fbcde1 View commit details
    Browse the repository at this point in the history