Suggest a positional formatting argument instead of a captured argument #100058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
Can you add tests for different format arg types, like Debug |
|
☔ The latest upstream changes (presumably #100063) made this pull request unmergeable. Please resolve the merge conflicts. |
TaKO8Ki
force-pushed
the
suggest-positional-formatting-argument-instead-of-format-args-capture
branch
from
c01bb16
to
a0a2ec3
Compare
|
@compiler-errors I added them! |
estebank
reviewed
Aug 3, 2022
estebank
reviewed
Aug 3, 2022
estebank
reviewed
Aug 3, 2022
estebank
reviewed
Aug 3, 2022
estebank
reviewed
Aug 4, 2022
| let byte_pos = self.to_span_index(end); | ||
| let start = InnerOffset(byte_pos.0 + 1); | ||
| let field = self.argument(start); | ||
| if !self.consume('}') { |
There was a problem hiding this comment.
Can we add a comment stating "We can only parse foo.bar field access, any deeper nesting, or another type of expression, like method calls, are not supported".
estebank
approved these changes
Aug 4, 2022
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 4, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#98796 (Do not exclusively suggest `;` when `,` is also a choice) - rust-lang#99772 (Re-enable submodule archive downloads.) - rust-lang#100058 (Suggest a positional formatting argument instead of a captured argument) - rust-lang#100093 (Enable unused_parens for match arms) - rust-lang#100095 (More EarlyBinder cleanups) - rust-lang#100138 (Remove more Clean trait implementations) - rust-lang#100148 (RustWrapper: update for TypedPointerType in LLVM) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
TaKO8Ki
deleted the
suggest-positional-formatting-argument-instead-of-format-args-capture
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a part of #96999.
fixes #98241
fixes #97311
r? @estebank