Add error if link_ordinal used with unsupported link kind #100069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @ehuss |
15 tasks
This comment has been minimized.
This comment has been minimized.
luqmana
reviewed
Aug 5, 2022
There was a problem hiding this comment.
Thanks for the PR, @dpaoliello!
I think the error message would be more helpful if it was
#[link_ordinal]is only supported if link kind israw-dylib
that is, if raw-dylib was mentioned explicitly.
Other than that, this looks good to go.
michaelwoerister
approved these changes
Aug 9, 2022
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 10, 2022
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#99573 (Stabilize backtrace) - rust-lang#100069 (Add error if link_ordinal used with unsupported link kind) - rust-lang#100086 (Add more `// unit-test`s to MIR opt tests) - rust-lang#100332 (Rename integer log* methods to ilog*) - rust-lang#100334 (Suggest a missing semicolon before an array) - rust-lang#100340 (Iterate generics_def_id_map in reverse order to fix P-critical issue) - rust-lang#100345 (docs: remove repetition in `is_numeric` function docs) - rust-lang#100352 (Update cargo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
link_ordinalattribute only has an affect if theraw-dyliblink kind is used, so add an error if it is used with any other link kind.