Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add miri-test-libstd support to libstd #100129

Merged
merged 5 commits into from
Aug 20, 2022
Merged

add miri-test-libstd support to libstd #100129

merged 5 commits into from
Aug 20, 2022

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Aug 4, 2022 •
edited
Loading

  • The first commit mirrors what we already have in liballoc.
  • The second commit adds some regression tests that only really make sense to be run in Miri, since they rely on Miri's extra checks to detect anything.
  • The third commit makes the MPSC tests work in reasonable time in Miri by reducing iteration counts.
  • The fourth commit silences some warnings due to code being disabled with cfg(miri)

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Aug 4, 2022
@rustbot
Copy link
Collaborator

rustbot commented Aug 4, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2022
@RalfJung RalfJung force-pushed the miri-test-libstd branch 6 times, most recently from 8154c76 to 96c7dc9 Compare August 6, 2022 00:43
@RalfJung
Copy link
Member Author

r? @thomcc

@rust-highfive rust-highfive assigned thomcc and unassigned m-ou-se Aug 10, 2022
@RalfJung
Copy link
Member Author

r? libs

@rust-highfive rust-highfive assigned joshtriplett and unassigned thomcc Aug 16, 2022
@RalfJung
Copy link
Member Author

r? libs

@thomcc
Copy link
Member

thomcc commented Aug 18, 2022 •
edited
Loading

(per request in https://rust-lang.zulipchat.com/#narrow/stream/219381-t-libs/topic/Review.20for.20.23100129)

r? @thomcc

@rust-highfive rust-highfive assigned thomcc and unassigned m-ou-se Aug 18, 2022
thomcc
thomcc approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. r=me with nits addressed.

library/alloc/src/lib.rs Outdated Show resolved Hide resolved
library/alloc/src/sync/tests.rs Show resolved Hide resolved
library/std/src/lib.rs Outdated Show resolved Hide resolved
@thomcc
Copy link
Member

thomcc commented Aug 18, 2022

Nits seem to be addressed. Feel free to r=me if there's nothing else you want.

@RalfJung
Copy link
Member Author

@bors r=thomcc

@bors
Copy link
Contributor

bors commented Aug 19, 2022

📌 Commit fbcdf2a has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 20, 2022
@matthiaskrgr
Rollup merge of rust-lang#100129 - RalfJung:miri-test-libstd, r=thomcc
80fa648 
add miri-test-libstd support to libstd

- The first commit mirrors what we already have in liballoc.
- The second commit adds some regression tests that only really make sense to be run in Miri, since they rely on Miri's extra checks to detect anything.
- The third commit makes the MPSC tests work in reasonable time in Miri by reducing iteration counts.
- The fourth commit silences some warnings due to code being disabled with `cfg(miri)`
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 20, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 20, 2022
@matthiaskrgr
Rollup merge of rust-lang#100129 - RalfJung:miri-test-libstd, r=thomcc
ce9b9ab 
add miri-test-libstd support to libstd

- The first commit mirrors what we already have in liballoc.
- The second commit adds some regression tests that only really make sense to be run in Miri, since they rely on Miri's extra checks to detect anything.
- The third commit makes the MPSC tests work in reasonable time in Miri by reducing iteration counts.
- The fourth commit silences some warnings due to code being disabled with `cfg(miri)`
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 20, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 20, 2022
@matthiaskrgr
Rollup merge of rust-lang#100129 - RalfJung:miri-test-libstd, r=thomcc
6c734ec 
add miri-test-libstd support to libstd

- The first commit mirrors what we already have in liballoc.
- The second commit adds some regression tests that only really make sense to be run in Miri, since they rely on Miri's extra checks to detect anything.
- The third commit makes the MPSC tests work in reasonable time in Miri by reducing iteration counts.
- The fourth commit silences some warnings due to code being disabled with `cfg(miri)`
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 20, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 20, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 20, 2022
@bors
Auto merge of rust-lang#100810 - matthiaskrgr:rollup-xep778s, r=matth…
878aef7 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#97963 (net listen backlog set to negative on Linux.)
 - rust-lang#99935 (Reenable disabled early syntax gates as future-incompatibility lints)
 - rust-lang#100129 (add miri-test-libstd support to libstd)
 - rust-lang#100500 (Ban references to `Self` in trait object substs for projection predicates too.)
 - rust-lang#100636 (Revert "Revert "Allow dynamic linking for iOS/tvOS targets."")
 - rust-lang#100718 ([rustdoc] Fix item info display)
 - rust-lang#100769 (Suggest adding a reference to a trait assoc item)
 - rust-lang#100777 (elaborate how revisions work with FileCheck stuff in src/test/codegen)
 - rust-lang#100796 (Refactor: remove unnecessary string searchings)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e93edf3 into rust-lang:master Aug 20, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 20, 2022
@RalfJung RalfJung deleted the miri-test-libstd branch August 21, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcc thomcc thomcc approved these changes

Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
7 participants
@RalfJung @rustbot @rust-highfive @thomcc @bors @joshtriplett @m-ou-se