Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid ICE in rustdoc when using Fn bounds #100205

Merged
merged 3 commits into from
Aug 9, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/librustdoc/clean/auto_trait.rs
Original file line number Diff line number Diff line change
Expand Up @@ -354,9 +354,7 @@ where
ty_to_bounds
.into_iter()
.flat_map(|(ty, mut bounds)| {
if let Some(data) = ty_to_fn.get(&ty) {
let (poly_trait, output) =
(data.0.as_ref().unwrap().clone(), data.1.as_ref().cloned().map(Box::new));
if let Some((Some(ref poly_trait), ref output)) = ty_to_fn.get(&ty) {
camelid marked this conversation as resolved.
Show resolved Hide resolved
let mut new_path = poly_trait.trait_.clone();
let last_segment = new_path.segments.pop().expect("segments were empty");

Expand All @@ -374,8 +372,9 @@ where
GenericArgs::Parenthesized { inputs, output } => (inputs, output),
};

let output = output.as_ref().cloned().map(Box::new);
if old_output.is_some() && old_output != output {
panic!("Output mismatch for {:?} {:?} {:?}", ty, old_output, data.1);
panic!("Output mismatch for {:?} {:?} {:?}", ty, old_output, output);
}

let new_params = GenericArgs::Parenthesized { inputs: old_input, output };
Expand All @@ -385,7 +384,10 @@ where
.push(PathSegment { name: last_segment.name, args: new_params });

bounds.insert(GenericBound::TraitBound(
PolyTrait { trait_: new_path, generic_params: poly_trait.generic_params },
PolyTrait {
trait_: new_path,
generic_params: poly_trait.generic_params.clone(),
},
hir::TraitBoundModifier::None,
));
}
Expand Down
17 changes: 17 additions & 0 deletions src/test/rustdoc/fn-bound.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
use std::iter::Peekable;
camelid marked this conversation as resolved.
Show resolved Hide resolved

pub struct Span<F: Fn(&i32)> {
inner: Peekable<ConditionalIterator<F>>,
}

struct ConditionalIterator<F> {
f: F,
}

impl<F: Fn(&i32)> Iterator for ConditionalIterator<F> {
camelid marked this conversation as resolved.
Show resolved Hide resolved
type Item = ();

fn next(&mut self) -> Option<Self::Item> {
todo!()
}
}