Do not consider method call receiver as an argument in AST. #100232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
|
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
fmease
reviewed
Aug 7, 2022
This comment has been minimized.
This comment has been minimized.
cjgillot
force-pushed
the
no-desugar-methodcall
branch
from
795e4a7
to
6525bd8
Compare
|
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt |
cjgillot
force-pushed
the
no-desugar-methodcall
branch
from
6525bd8
to
b68402a
Compare
This comment has been minimized.
This comment has been minimized.
nagisa
reviewed
Aug 7, 2022
| let hir_seg = self.arena.alloc(self.lower_path_segment( | ||
| e.span, | ||
| seg, | ||
| ParamMode::Optional, | ||
| ParenthesizedGenericArgs::Err, | ||
| ImplTraitContext::Disallowed(ImplTraitPosition::Path), | ||
| )); | ||
| let args = self.lower_exprs(args); | ||
| let args = self.arena.alloc_from_iter( | ||
| [&*receiver].into_iter().chain(args.iter()).map(|x| self.lower_expr_mut(x)), |
There was a problem hiding this comment.
Given how much better the AST is from having the receiver be separate, it makes me wonder if HIR would benefit just as much…
nagisa
approved these changes
Aug 7, 2022
cjgillot
force-pushed
the
no-desugar-methodcall
branch
from
2402ca1
to
934d69a
Compare
This comment has been minimized.
This comment has been minimized.
cjgillot
force-pushed
the
no-desugar-methodcall
branch
from
934d69a
to
69205db
Compare
|
@bors r=nagisa |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 11, 2022
Rollup of 11 pull requests Successful merges: - rust-lang#92744 (Check if enum from foreign crate has any non exhaustive variants when attempting a cast) - rust-lang#99110 (Determine match_has_guard from candidates instead of looking up thir table again) - rust-lang#100184 (Stabilize ptr_const_cast) - rust-lang#100192 ( Remove duplicated temporaries creating during box derefs elaboration) - rust-lang#100232 (Do not consider method call receiver as an argument in AST.) - rust-lang#100287 (linux: Use `pthread_setname_np` instead of `prctl`) - rust-lang#100351 (Use `&mut Diagnostic` instead of `&mut DiagnosticBuilder` unless needed) - rust-lang#100370 (Remove more Clean trait implementations) - rust-lang#100391 (Improve size assertions) - rust-lang#100398 (Improve `-Zhir-stats`) - rust-lang#100403 (Improve error messages when running rustdoc GUI tests) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 5, 2022
…ents-in-hir, r=cjgillot Separate the receiver from arguments in HIR Related to rust-lang#100232 cc `@cjgillot`
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 9, 2022
…ents-in-hir, r=cjgillot Separate the receiver from arguments in HIR Related to rust-lang#100232 cc `@cjgillot`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 28, 2022
…s-split, r=pnkfelix Revert "Do not consider method call receiver as an argument in AST." Reverts rust-lang#100232, including a few places where there were merge conflicts after this landed. r? `@pnkfelix` cc `@cjgillot` cc rust-lang#103430 the nightly workaround for this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73663