Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Miri #100495

Merged
merged 1 commit into from
Aug 14, 2022
Merged

update Miri #100495

merged 1 commit into from
Aug 14, 2022
+1 −1

Conversation

RalfJung
Copy link
Member

Fixes #100424

@rustbot
Copy link
Collaborator

rustbot commented Aug 13, 2022

The Miri submodule was changed

cc @rust-lang/miri

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 13, 2022
@RalfJung
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Aug 13, 2022

📌 Commit f3fc1cd has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2022
@bors
Copy link
Collaborator

bors commented Aug 13, 2022

⌛ Testing commit f3fc1cd with merge 12586a2df37e83659a6ab4f7a79b87f235b3414b...

@bors
Copy link
Collaborator

bors commented Aug 13, 2022

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 13, 2022
@RalfJung
Copy link
Member Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2022
@bors
Copy link
Collaborator

bors commented Aug 13, 2022

⌛ Testing commit f3fc1cd with merge 10d4c39b49f20265f34df4bcbd44614f8b4ecd53...

@rust-log-analyzer

This comment was marked as resolved.

Sign in to view
@bors
Copy link
Collaborator

bors commented Aug 14, 2022

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 14, 2022
@RalfJung
Copy link
Member Author

@bors retry what's up with the windows builders?

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2022
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Aug 14, 2022

⌛ Testing commit f3fc1cd with merge d70c0ec...

@bors
Copy link
Collaborator

bors commented Aug 14, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing d70c0ec to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 14, 2022
@bors bors merged commit d70c0ec into rust-lang:master Aug 14, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 14, 2022
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #100495!

Tested on commit d70c0ec.
Direct link to PR: #100495

🎉 miri on linux: test-fail → test-pass (cc @RalfJung @oli-obk).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Aug 14, 2022
@rust-highfive
📣 Toolstate changed by rust-lang/rust#100495!
455ab57 
Tested on commit rust-lang/rust@d70c0ec.
Direct link to PR: <rust-lang/rust#100495>

🎉 miri on linux: test-fail → test-pass (cc @RalfJung @oli-obk).
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d70c0ec): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions ❌
(primary)		 2.1% 2.1% 1
Regressions ❌
(secondary)		 3.1% 3.1% 1
Improvements ✅
(primary)		 -0.5% -0.5% 1
Improvements ✅
(secondary)		 -3.4% -3.4% 2
All ❌✅ (primary) 0.8% 2.1% 2

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩

  2. number of relevant changes ↩

@RalfJung RalfJung deleted the miri branch August 14, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#100416
7 participants
@RalfJung @rustbot @rust-highfive @bors @rust-log-analyzer @rust-timer @Mark-Simulacrum