trans: add range asserts to loads of char
#10056
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What does this change do and why? |
|
@brson: It marks characters as being in the valid range like we do for booleans, but I didn't realize that there were still transmutes of |
|
(The lexer and json module rely heavily on being able to transmute |
|
Thanks for the explanation. |
|
I'll reopen this when the issues are fixed. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 29, 2022
Avoid `match_wildcard_for_single_variants` on guarded wild matches fix rust-lang#9993 changelog: FP: [`match_wildcard_for_single_variants`]: No longer lints on wildcards with a guard [rust-lang#10056](rust-lang/rust-clippy#10056) <!-- changelog_checked --> r? `@Jarcho`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.