-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add next_up and next_down for f32/f64 - take 2 #100578
Conversation
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Thanks for reviving this! @bors r+ rollup=iffy (probably fine this time, but previously failed in 32-bit i386 so might want its own bors run) |
I'd just like to say that my pull request hasn't really stalled due to inactivity, but due to me not knowing what to do about this unresolved question: #91399 (comment) |
@orlp I guess I'm happy saying that that's something that might block stabilization, but don't need to keep it from going into nightly. (Unless libs-api previously said otherwise, since its their call.) |
☀️ Test successful - checks-actions |
Finished benchmarking commit (1ea4efd): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Footnotes |
This is a revival of #88728 which staled due to inactivity of the original author. I've address the last review comment.
This is a pull request implementing the features described at rust-lang/rfcs#3173.
@rustbot label +T-libs-api -T-libs
r? @scottmcm
cc @orlp