Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #100662

Closed
wants to merge 11 commits into from
Closed

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Aug 17, 2022

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

eholk and others added 11 commits July 29, 2022 15:59
IEEE-754, not IEEE-745. May save someone a second sometime
Quick pull request; IEEE-754, not IEEE-745. May save someone a quick second some time.
…d, r=cjgillot

Make must_not_suspend lint see through references when drop tracking is enabled

See rust-lang#97333.

With drop tracking enabled, sometimes values that were previously linted are now considered dropped and not linted. This change makes must_not_suspend traverse through references to still catch these values.

Unfortunately, this leads to duplicate warnings in some cases (e.g. [dedup.rs](https://cs.github.com/rust-lang/rust/blob/9a74608543d499bcc7dd505e195e8bfab9447315/src/test/ui/lint/must_not_suspend/dedup.rs#L4)), so we only use the new behavior when drop tracking is enabled.

cc `@guswynn`
…acrum

unwind: don't build dependency when building for Miri

This is basically re-submitting rust-lang#94813.

In that PR there was a suggestion to instead have bootstrap set a `RUST_CHECK` env var and use that rather than doing something Miri-specific. However, such an env var would mean that when switching between `./x.py check` and `./x.py build`, the build script gets re-run each time, which doesn't seem good. So I think for now checking for Miri probably causes fewer problems.

r? ``@Mark-Simulacrum``
Fixed a few documentation errors

Quick pull request; IEEE-754, not IEEE-745. May save someone a quick second some time.
Fixed a few documentation errors

Quick pull request; IEEE-754, not IEEE-745. May save someone a quick second some time.
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Aug 17, 2022
@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Aug 17, 2022

@bors r+ rollup=never p=4

@bors
Copy link
Contributor

bors commented Aug 17, 2022

📌 Commit c70f46d has been approved by TaKO8Ki

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 17, 2022
@matthiaskrgr
Copy link
Member

rolling up 4 prs when there are 30 prs waiting in the queue is kinda kinda pointless.
This will just unnecessarily block rollup=never prs from going in

@compiler-errors
Copy link
Member

@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Aug 17, 2022

@matthiaskrgr @compiler-errors Sorry. I understand.

@bors
Copy link
Contributor

bors commented Aug 17, 2022

⌛ Testing commit c70f46d with merge 8dc78db3c33a69e8183e1a36e5bbc429a4c54264...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@TaKO8Ki TaKO8Ki deleted the rollup-qsveru2 branch August 21, 2022 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants