Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Miri #100682

Merged
merged 1 commit into from
Aug 18, 2022
Merged

update Miri #100682

merged 1 commit into from
Aug 18, 2022

Conversation

RalfJung
Copy link
Member

Fixes #100614
r? @ghost

@rustbot
Copy link
Collaborator

rustbot commented Aug 17, 2022

The Miri submodule was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Aug 17, 2022

📌 Commit 2c9baf7 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 17, 2022
@bors
Copy link
Contributor

bors commented Aug 17, 2022

⌛ Testing commit 2c9baf7 with merge 2d99ecd0185c64497550787b4a261165d88d8377...

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 17, 2022
@matthiaskrgr
Rollup merge of rust-lang#100682 - RalfJung:miri, r=RalfJung
e76d218 
update Miri

Fixes rust-lang#100614
r? `@ghost`
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 17, 2022
Closed
@bors
Copy link
Contributor

bors commented Aug 17, 2022

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 17, 2022
@matthiaskrgr
Copy link
Member

@bors retry timeout

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 17, 2022
@matthiaskrgr
Rollup merge of rust-lang#100682 - RalfJung:miri, r=RalfJung
1254057 
update Miri

Fixes rust-lang#100614
r? `@ghost`
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 17, 2022
Closed
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Aug 18, 2022

⌛ Testing commit 2c9baf7 with merge 4993a76db9d295f5d2b9ce2a4946d841c01e7acb...

@bors
Copy link
Contributor

bors commented Aug 18, 2022

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 18, 2022
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@RalfJung
Copy link
Member Author

@bors retry timeout in x86_64-mingw-1

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2022
@bors
Copy link
Contributor

bors commented Aug 18, 2022

⌛ Testing commit 2c9baf7 with merge bb99e6f...

@bors
Copy link
Contributor

bors commented Aug 18, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing bb99e6f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 18, 2022
@bors bors merged commit bb99e6f into rust-lang:master Aug 18, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 18, 2022
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #100682!

Tested on commit bb99e6f.
Direct link to PR: #100682

🎉 miri on windows: build-fail → test-pass (cc @RalfJung @oli-obk).
🎉 miri on linux: build-fail → test-pass (cc @RalfJung @oli-obk).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Aug 18, 2022
@rust-highfive
📣 Toolstate changed by rust-lang/rust#100682!
a35cce2 
Tested on commit rust-lang/rust@bb99e6f.
Direct link to PR: <rust-lang/rust#100682>

🎉 miri on windows: build-fail → test-pass (cc @RalfJung @oli-obk).
🎉 miri on linux: build-fail → test-pass (cc @RalfJung @oli-obk).
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bb99e6f): comparison url.

Instruction count

  • Primary benchmarks: ✅ relevant improvements found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.9% -0.9% 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.9% -0.9% 2

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.2% 3.2% 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.3% -2.6% 3
All ❌✅ (primary) - - 0

Cycles

Results
  • Primary benchmarks: ✅ relevant improvement found
  • Secondary benchmarks: ✅ relevant improvement found
mean1 max count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.1% -3.1% 1
Improvements ✅
(secondary)		 -2.3% -2.3% 1
All ❌✅ (primary) -3.1% -3.1% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@RalfJung RalfJung deleted the miri branch August 18, 2022 17:09
@RalfJung
Copy link
Member Author

Looks like a noisy benchmark, this certainly didn't change compiler performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#100611
7 participants
@RalfJung @rustbot @bors @matthiaskrgr @rust-log-analyzer @rust-highfive @rust-timer