Align android sigaddset impl with the reference impl from Bionic

[thomcc]

In #100737 I noticed we were treating the sigset_t as an array of bytes, while referencing code from android (https://github.com/aosp-mirror/platform_bionic/blob/ad8dcd6023294b646e5a8288c0ed431b0845da49/libc/include/android/legacy_signal_inlines.h) which treats it as an array of unsigned long.

That said, the behavior difference is so subtle here that it's not hard to see why nobody noticed. This fixes the implementation to be equivalent to the one in bionic.

[rustbot]

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

• Stabilizing library features
• Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
• Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
• Changing public documentation in ways that create new stability guarantees
• Changing observable runtime behavior of library APIs

[rust-highfive]

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

[Mark-Simulacrum]

@bors r+ rollup

[bors]

📌 Commit f506656 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

[matthiaskrgr]

@bors r- failed in a rollup
#100828 (comment)

[thomcc]

@bors try

(I think this includes the stuff that failed?)

[bors]

⌛ Trying commit 4ecf876 with merge 5b1f98a3aa6cd874cb1f46edf817e39e6ffb89c6...

[matthiaskrgr]

This failed on the dist-android builder, so probably not :/

[thomcc]

Huh, I thought try ran the same tests that run on rollup (I guess I just assumed this. in my defense, this is more or less what try was used for on firefox).

Is there an easy way to do that?

[thomcc]

I guess I can make it fail here with rollup=never, and at least this way it won't cause someone else trouble. Ideally I'd have a local android dev env set up, but mine broke a few months ago and I haven't gotten around to it.

@bors r=Mark-Simulacrum rollup=never

[bors]

📌 Commit 4ecf876 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

[bors]

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 5b1f98a3aa6cd874cb1f46edf817e39e6ffb89c6 to master...

[bors]

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

[matthiaskrgr]

Ouff, do we still have bug that when we bors try and r+ while the pr is compiling for try the try build would try to merge it right away because its "approved" now?

[rust-timer]

Finished benchmarking commit (5b1f98a3aa6cd874cb1f46edf817e39e6ffb89c6): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	2.4%	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.9%	-2.9%	1
All ❌✅ (primary)	-	-	0

Cycles

Results

• Primary benchmarks: mixed results
• Secondary benchmarks: no relevant changes found

	mean1	max	count2
Regressions ❌ (primary)	1.9%	1.9%	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.7%	-3.7%	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.9%	-3.7%	2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²

[Mark-Simulacrum]

OK, please don't try and then r+ in the future (until rust-lang/homu#47 is fixed).

Otherwise I think @bors r=Mark-Simulacrum rollup=never is reasonable.

We can make try builds run android with some work -- there's some documentation here: https://rustc-dev-guide.rust-lang.org/tests/ci.html#using-ci-to-test

[bors]

💡 This pull request was already approved, no need to approve it again.

• This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
• There's another pull request that is currently being tested, blocking this pull request: Kind-less SessionDiagnostic derive #100765

[bors]

📌 Commit 4ecf876 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

[thomcc]

OK, please don't try and then r+ in the future (until rust-lang/homu#47 is fixed

Noted, thanks, I didn't realize that bug existed.

[bors]

⌛ Testing commit 4ecf876 with merge 1cff564...

[bors]

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 1cff564 to master...

[rust-timer]

Finished benchmarking commit (1cff564): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.8%	[4.0%, 5.9%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.3%	[-3.3%, -3.3%]	1
All ❌✅ (primary)	-	-	0

Footnotes

1. the arithmetic mean of the percent change ↩

2. number of relevant changes ↩