Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the define_query macro #100943

Merged
merged 7 commits into from
Sep 2, 2022
Merged

Simplify the define_query macro #100943

merged 7 commits into from
Sep 2, 2022

Commits on Sep 1, 2022

  1. Get rid of make_query module

    @jyn514
    jyn514 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    1cf7bcc View commit details
    Browse the repository at this point in the history

  2. Move try_on_disk_cache out of the giant macro

    @jyn514
    jyn514 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    375d780 View commit details
    Browse the repository at this point in the history

  3. Move force_with_dep_node outside the giant macro

    @jyn514
    jyn514 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    70f20ac View commit details
    Browse the repository at this point in the history

  4. Get rid of fn recover

    @jyn514
    jyn514 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    8f442e8 View commit details
    Browse the repository at this point in the history

  5. Move almost all of the function in query_callbacks to a generic fun… 

    …ction
    @jyn514
    jyn514 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    83b6dc9 View commit details
    Browse the repository at this point in the history

  6. Simplify try_load_from_on_disk_cache

    @jyn514
    jyn514 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    4fcc745 View commit details
    Browse the repository at this point in the history

  7. Don't create two new closures for each query 

    - Parameterize DepKindStruct over `'tcx`

    This allows passing in an invariant function pointer in `query_callback`,
    rather than having to try and make it work for any lifetime.

- Add a new `execute_query` function to `QueryDescription` so we can call `tcx.$name` without needing to be in a macro context
    @jyn514
    jyn514 committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    4e09a13 View commit details
    Browse the repository at this point in the history