Under Miri, disable debug asserts for things Miri always checks #101079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-libs
|
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @ghost |
|
@rustbot author |
rustbot
added
S-waiting-on-author
saethlin
force-pushed
the
redundant-miri-checks
branch
2 times, most recently
from
30d6ce8
to
680f167
Compare
This comment has been minimized.
This comment has been minimized.
saethlin
force-pushed
the
redundant-miri-checks
branch
from
680f167
to
388dd8b
Compare
|
☔ The latest upstream changes (presumably #100759) made this pull request unmergeable. Please resolve the merge conflicts. |
saethlin
force-pushed
the
redundant-miri-checks
branch
from
388dd8b
to
3ea7fa3
Compare
saethlin
force-pushed
the
redundant-miri-checks
branch
from
3ea7fa3
to
da79af7
Compare
|
☔ The latest upstream changes (presumably #103562) made this pull request unmergeable. Please resolve the merge conflicts. |
saethlin
force-pushed
the
redundant-miri-checks
branch
from
da79af7
to
7710d6c
Compare
|
☔ The latest upstream changes (presumably #103623) made this pull request unmergeable. Please resolve the merge conflicts. |
saethlin
force-pushed
the
redundant-miri-checks
branch
from
7710d6c
to
80b6a04
Compare
|
I'm not sure the magnitude of the effect here is worth the complexity of implementation. Maybe if we had a different implementation strategy it might make sense, but the scary heavyweight debug assertions for container invariants aren't/can't be covered by this strategy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: rust-lang/miri#2497, Miri currently disables debug assertions in the standard library out of concern for how much slower code runs under Miri. A significant contributor there are these checks, which are entirely redundant and occur before Miri's, resulting in a much worse user experience if they are actually hit. So there is no reason to have them enabled under Miri.
However, this leaves some checks still enabled. Most notably, the bounds check(s) on
slice::get_uncheckedis staying put. This precondition originates in the requirements of Stacked Borrows, which can be disabled, and also has nothing to say about ZSTs, where the library API forbids out-of-bounds indexing, even for ZSTs.