Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate another part of rustc_infer to session diagnostic #101153

Merged
merged 8 commits into from
Sep 8, 2022
Merged

Migrate another part of rustc_infer to session diagnostic #101153

merged 8 commits into from
Sep 8, 2022

Conversation

IntQuant
Copy link
Contributor

Probably will migrate another file before marking this one as ready-to-merge.

@rustbot label +A-translation
r? rust-lang/diagnostics
cc #100717

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 29, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 29, 2022
@davidtwco davidtwco mentioned this pull request Aug 30, 2022
Open
84 tasks
@IntQuant IntQuant marked this pull request as ready for review August 30, 2022 16:09
@rustbot
Copy link
Collaborator

rustbot commented Aug 30, 2022

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

davidtwco
davidtwco requested changes Aug 31, 2022
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, I've left an initial batch of comments.

compiler/rustc_infer/src/infer/error_reporting/nice_region_error/different_lifetimes.rs Outdated Show resolved Hide resolved
compiler/rustc_infer/src/lib.rs Outdated Show resolved Hide resolved
compiler/rustc_infer/src/errors/mod.rs Show resolved Hide resolved
compiler/rustc_infer/src/errors/mod.rs Outdated Show resolved Hide resolved
compiler/rustc_infer/src/errors/mod.rs Outdated Show resolved Hide resolved
compiler/rustc_infer/src/errors/mod.rs Outdated Show resolved Hide resolved
compiler/rustc_infer/src/errors/mod.rs Outdated Show resolved Hide resolved
compiler/rustc_infer/src/errors/note_and_explain.rs Outdated Show resolved Hide resolved
compiler/rustc_infer/src/errors/note_and_explain.rs Outdated Show resolved Hide resolved
compiler/rustc_error_messages/locales/en-US/infer.ftl Show resolved Hide resolved
@compiler-errors
Copy link
Member

r? @davidtwco

@rustbot
Copy link
Collaborator

rustbot commented Sep 6, 2022

Some changes occurred in need_type_info.rs

cc @lcnr

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@davidtwco
Copy link
Member

Thanks! This is fantastic.

@bors r+

@bors
Copy link
Contributor

bors commented Sep 7, 2022

📌 Commit 3d70be7 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 8, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 8, 2022
@bors
Auto merge of rust-lang#101560 - Dylan-DPC:rollup-8m8yr89, r=Dylan-DPC
b42244c 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#101153 (Migrate another part of rustc_infer to session diagnostic)
 - rust-lang#101399 (Shrink span for bindings with subpatterns.)
 - rust-lang#101422 (Hermit: Add File::set_time stub)
 - rust-lang#101455 (Avoid UB in the Windows filesystem code in... bootstrap?)
 - rust-lang#101498 (rustc: Parameterize `ty::Visibility` over used ID)
 - rust-lang#101549 (Use HashStable_Generic in rustc_type_ir)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e3ea800 into rust-lang:master Sep 8, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 8, 2022
@davidtwco davidtwco mentioned this pull request Sep 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth left review comments

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
8 participants
@IntQuant @rustbot @compiler-errors @rust-log-analyzer @davidtwco @bors @Manishearth @rust-highfive