Restore old behaviour on broken UNC paths #101366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-libs
rust-highfive
added
the
S-waiting-on-review
ChrisDenton
force-pushed
the
unc-forward-slash
branch
from
dfb62a5
to
0fe54d4
Compare
Mark-Simulacrum
added
the
beta-nominated
|
Beta nominating to highlight it for discussion. Is this a regression in beta? Or older, but just want the fix out sooner? |
|
It's a regression already in stable but I'm mildly keen to get a fix into the earliest stable version possible. I don't like breaking people's applications. That said, it's been broken for quite awhile (edit: oh, since 1.62!) and apparently nobody noticed until now so I suppose it's not essential. |
m-ou-se
added
the
stable-nominated
|
@bors r+ |
bors
added
S-waiting-on-bors
m-ou-se
added
beta-accepted
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 9, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#101366 (Restore old behaviour on broken UNC paths) - rust-lang#101492 (Suggest adding array lengths to references to arrays if possible) - rust-lang#101529 (Fix the example code and doctest for Formatter::sign_plus) - rust-lang#101573 (update `ParamKindOrd`) - rust-lang#101612 (Fix code generation of `Rvalue::Repeat` with 128 bit values) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
pietroalbini
removed
beta-nominated
|
Not going to be backported to stable. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 19, 2022
[stable] Prepare 1.64.0 release This PR prepares the 1.64.0 stable release builds. In addition to bumping the channel and including the latest release notes changes, this PR also backports the following PRs: * rust-lang#100852 * rust-lang#101366 * rust-lang#101468 * rust-lang#101922 This PR also reverts the following PRs, as decided in rust-lang#101899 (comment): * rust-lang#95295 * rust-lang#99136 (followup to the previous PR) r? `@ghost` cc `@rust-lang/release`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #101358 by restoring the behaviour from previous stable Rust versions. I'm not convinced this is ultimately right but I think it's less wrong and maybe this should be backported to beta?
r? libs