-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a codegen test for rust-lang/rust#96152 #101395
Conversation
@bors r+ rollup=never because assembly test |
📌 Commit f2e97c21c4c5364a24bcd3d1690b976894481f52 has been approved by It is now in the queue for this repository. |
⌛ Testing commit f2e97c21c4c5364a24bcd3d1690b976894481f52 with merge d87f187062fd52f04dee9598c20ebfbcd76d48ed... |
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
@bors retry looks spurious |
⌛ Testing commit f2e97c21c4c5364a24bcd3d1690b976894481f52 with merge 3a1734e1819fd9f8ec3b0f87fb4945262907d9b8... |
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
The tests pass on Linux and I have no idea how to debug the problem here. At a guess the Windows linker is misbehaving. |
This is just a difference in calling convention. With the sysv ABI, the first argument is passed in rdi, with ms abi it is passed in rcx. You could either use a wildcard like |
f2e97c2
to
b97ec85
Compare
I really wish the error message indicated that it was just one instruction off. When I read over it, I thought two of the functions were missing from the assembly. |
@bors r+ |
⌛ Testing commit b97ec85 with merge 3ea51b569dc3de3f39b0a71bab72d4e61038543a... |
💔 Test failed - checks-actions |
The job Click to see the possible cause of the failure (guessed by this bot)
|
@bors retry |
☀️ Test successful - checks-actions |
Finished benchmarking commit (391ba78): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Obviously noise, as this PR didn't actually modify any compiler code. @rustbot label: +perf-regression-triaged |
This is a regression test for #96152, it is intended to check that our codegen for a particular strict provenance pattern is always as good as the ptr2int2ptr/provenance-ignoring style.
r? @nikic