Report number of delayed bugs properly with -Ztreat-err-as-bug
#101471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
compiler-errors
force-pushed
the
delay-bug-are-count-too
branch
from
6bff036 to
0ca4271
Compare
compiler-errors
force-pushed
the
delay-bug-are-count-too
branch
from
0ca4271 to
38935bb
Compare
compiler-errors
commented
Sep 6, 2022
| self.flags.treat_err_as_bug.map(|c| c.get()).unwrap_or(0), | ||
| ) { | ||
| (1, 1) => panic!("aborting due to `-Z treat-err-as-bug=1`"), | ||
| (0 | 1, _) => {} |
There was a problem hiding this comment.
This will literally never trigger -- because if the err count is 0 or 1, then for self.treat_err_as_bug() to have evaluated to true, then we must have -Ztreat-err-as-bug=1, which would have matched the previous arm.
|
aaaa I literally hit that last week. Thank you! @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 6, 2022
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#101357 (Include enum path in variant suggestion) - rust-lang#101434 (Update `SessionDiagnostic::into_diagnostic` to take `Handler` instead of `ParseSess`) - rust-lang#101445 (Suggest introducing an explicit lifetime if it does not exist) - rust-lang#101457 (Recover from using `;` as separator between fields) - rust-lang#101462 (Rustdoc-Json: Store Variant Fields as their own item.) - rust-lang#101471 (Report number of delayed bugs properly with `-Ztreat-err-as-bug`) - rust-lang#101473 (Add more size assertions for MIR types.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report the number of delayed bugs that went into the
-Ztreat-errr-as-bug=Nbeing triggered, even if we don't count it in the err_count in regular diagnostic output.Sometimes we have a session that creates a few diagnostics, perhaps: Error, Delay bug, Error, then Delay bug.
If I ran
-Ztreat-err-as-bug=3, then I will now see "aborting after 2 errors and 1 delayed bugs" instead of just "after 2 errors" which is confusing since I passed3.