Skip to content

doc: some fixes #10150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

adrientetar
Copy link
Contributor

Noticeably closes #9981.

@alexcrichton

Note: checking '!== undefined' is unnecessary.

Closes rust-lang#9981.
@alexcrichton
Copy link
Member

Why were all of the three-tilde blocks migrated to four tildes? Did it not render correctly?

Also, I don't think that this is the right fix for the js searching, this is indicative of a bug in rustdoc, not a bug in the js search code. I'm not sure why parents are being emitted with no entries in the global array, privacy pruning should have gotten rid of everything. I'd want to understand what's causing the root of the problem rather than patching over it.

@adrientetar
Copy link
Contributor Author

That was just to normalize (in the doc there are stacks of 3 tildes, 4 tildes... on Windows at least tildes are emitted 2-by-2 so its easier with 4).
Yea I know it's more of a hack than a fix but search works ok again with that change. Well I'll just close this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Javascript error in rustdoc search
2 participants