Skip to content

Avoid infinite recursion on error case in get_path_res. #101513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Avoid infinite recursion on error case in get_path_res. #101513

wants to merge 1 commit into from

Conversation

nnethercote
Copy link
Contributor

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 7, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 7, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@matthiaskrgr
Copy link
Member

Could we move this forward somehow?
The bug prevents the my rust ice-discovery tooling from running properly 😓

@petrochenkov
Copy link
Contributor

@nnethercote

Is it an underlying bug that get_parent_node can return the same node it is given?

Likely yes.
Maybe the fresh HIR IDs created in #101228 do not setup their parenting relations correctly.
r? @cjgillot

@cjgillot cjgillot mentioned this pull request Sep 11, 2022
Merged
@cjgillot
Copy link
Contributor

Thanks for the ping. I took the opportunity to add a sanity check to HIR indexing to detect this sort of bug earlier in #101688.

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 12, 2022
@bors
Auto merge of rust-lang#101688 - cjgillot:verify-hir-parent, r=petroc…
fa521a4 
…henkov

Assert that HIR nodes are not their own parent.

Fixes rust-lang#101505.
Replaces rust-lang#101513

r? `@petrochenkov` `@nnethercote`
@nnethercote
Copy link
Contributor Author

Fixed in a better way by #101688.

@nnethercote nnethercote deleted the fix-101505 branch September 12, 2022 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

regression: hang with -Zsave-analysis
7 participants
@nnethercote @rust-log-analyzer @matthiaskrgr @petrochenkov @cjgillot @rust-highfive @rustbot