Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak future opaque ty pretty printing #101556

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Tweak future opaque ty pretty printing #101556

merged 2 commits into from
Sep 9, 2022

Conversation

compiler-errors
Copy link
Member

  1. The Return type of a generator doesn't need to be a lang item just for diagnostic printing of types
  2. We shouldn't suppress the Output = Ty of a opaque future if the type is a int or float var.

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 8, 2022
@rust-highfive
Copy link
Collaborator

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Sep 8, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 8, 2022
@compiler-errors
Copy link
Member Author

Gah, rebase failure.

@compiler-errors compiler-errors removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 8, 2022
@jackh726
Copy link
Member

jackh726 commented Sep 8, 2022

I don't know if I'm remembering wrong, but I had made a similar change before (maybe it was more general, all associated types? don't quite remember), but it had to be reverted because of something - I think symbol mangling?

Not really sure. Seems like a fairly simple change.

@compiler-errors
Copy link
Member Author

compiler-errors commented Sep 8, 2022 •
edited
Loading

@jackh726 do you mind trying to find that PR you mentioned?

This doesn't mess with the representation of the type -- do we use the printed name of the type in symbol mangling? Certainly we shouldn't have an unresolved infer var there even if we did.

I've touched this code a few times (I'm the one that added this lang item and added this special impl Future printing logic in the first place) so that kinda surprises me.

@jackh726
Copy link
Member

jackh726 commented Sep 8, 2022

It was probably something else :)

@bors r+

@bors
Copy link
Contributor

bors commented Sep 8, 2022

📌 Commit 97668a5 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 9, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 9, 2022
@bors
Auto merge of rust-lang#101603 - matthiaskrgr:rollup-8y6kf20, r=matth…
4a09adf 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#99207 (Enable eager checks for memory sanitizer)
 - rust-lang#101253 (fix the suggestion of format for asm_sub_register)
 - rust-lang#101450 (Add `const_extern_fn` to 1.62 release notes.)
 - rust-lang#101556 (Tweak future opaque ty pretty printing)
 - rust-lang#101563 (Link UEFI target documentation from target list)
 - rust-lang#101593 (Cleanup themes (tooltip))

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bdfbc35 into rust-lang:master Sep 9, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 9, 2022
@compiler-errors compiler-errors deleted the tweak-generator-print branch November 2, 2022 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jackh726 jackh726

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rust-highfive @rustbot @jackh726 @bors