Skip to content

Some perf experiments #101561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Some perf experiments #101561

wants to merge 1 commit into from

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Sep 8, 2022

r? @ghost

looking at regression from #99102 (comment)

@rustbot
Copy link
Collaborator

rustbot commented Sep 8, 2022

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 8, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented Sep 8, 2022

@bors try @rust-timer queue include=libc,bitmaps,many-assoc-items

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 8, 2022
@bors
Copy link
Collaborator

bors commented Sep 8, 2022

⌛ Trying commit 2c9cd17 with merge 10d870608eaa08538f193fe3a636577d0660000b...

@bors
Copy link
Collaborator

bors commented Sep 8, 2022

☀️ Try build successful - checks-actions
Build commit: 10d870608eaa08538f193fe3a636577d0660000b (10d870608eaa08538f193fe3a636577d0660000b)

@lqd
Copy link
Member

lqd commented Sep 8, 2022

the perf bot has probably lost this one ?!

@oli-obk
Copy link
Contributor Author

oli-obk commented Sep 9, 2022

@rust-timer build 10d870608eaa08538f193fe3a636577d0660000b

@rust-timer
Copy link
Collaborator

Queued 10d870608eaa08538f193fe3a636577d0660000b with parent 4af35b8, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (10d870608eaa08538f193fe3a636577d0660000b): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Sep 9, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented Sep 9, 2022

That was fast ?!

@oli-obk oli-obk closed this Sep 9, 2022
@oli-obk oli-obk deleted the mir_pass_opt branch September 9, 2022 13:30
@bugadani
Copy link
Contributor

bugadani commented Sep 9, 2022

"No results" on the comparison page.

@oli-obk
Copy link
Contributor Author

oli-obk commented Sep 9, 2022

I expanded the view, they are all too small to be shown. But if you select "Show non-relevant results" you'll get more data

@bugadani
Copy link
Contributor

bugadani commented Sep 9, 2022

Oh I thought nothing ran 😅

@lqd
Copy link
Member

lqd commented Sep 9, 2022

These 3 benchmarks are pretty quick to run and the queue was empty :)

@Mark-Simulacrum
Copy link
Member

#101561 (comment) included only a couple of benchmarks, though we should probably surface that on result completion too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants