-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify codeblock and their associated tooltip #101613
Conversation
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
This comment has been minimized.
This comment has been minimized.
I'll give it a try locally to see how it looks like but that seems like a really good idea. |
d07d814
to
a33c26e
Compare
Applied your idea and updated the online demo. |
@GuillaumeGomez Can you rebase this, please? |
a33c26e
to
8ba06d4
Compare
Done! |
@bors r+ rollup |
…r=notriddle Simplify codeblock and their associated tooltip It is based on rust-lang#101600 so it needs to wait for this one to be merged first. This PR does two things: * Remove CSS class duplication by setting CSS classes such as `compile_fail` directly on the `div` wrapping both the codeblock and the tooltip. * Simplify DOM: no need to wrap the tooltip into a `<div>`, it can work just as well without it. You can test it [here](https://rustdoc.crud.net/imperio/codeblock-tooltip/std/string/struct.String.html#deref). r? `@notriddle`
☀️ Test successful - checks-actions |
Finished benchmarking commit (781ef3e): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Footnotes |
Perf results are noise. No perf change should be detected in here. |
@rustbot label: +perf-regression-triaged |
It is based on #101600 so it needs to wait for this one to be merged first.
This PR does two things:
compile_fail
directly on thediv
wrapping both the codeblock and the tooltip.<div>
, it can work just as well without it.You can test it here.
r? @notriddle