Feature gate the rustdoc::missing_doc_code_examples lint
#101732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rustbot
added
the
T-rustdoc
|
r? @fee1-dead (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Nemo157
commented
Sep 12, 2022
| @@ -221,6 +221,8 @@ declare_features! ( | |||
| (active, rustc_private, "1.0.0", Some(27812), None), | |||
| /// Allows using internal rustdoc features like `doc(primitive)` or `doc(keyword)`. | |||
| (active, rustdoc_internals, "1.58.0", Some(90418), None), | |||
| /// Allows using the `rustdoc::missing_doc_code_examples` lint | |||
| (active, rustdoc_missing_doc_code_examples, "1.31.0", Some(101730), None), | |||
There was a problem hiding this comment.
This is the version the original lint merged into, I'm not sure if this should just use the current nightly version instead though?
There was a problem hiding this comment.
I suppose it doesn't matter much. The important version is the stable one once it gets stabilized.
Nemo157
force-pushed
the
gate-rustdoc-missing-examples
branch
from
0ea9508
to
d09ff68
Compare
|
Yes 🙄 |
GuillaumeGomez
approved these changes
Sep 12, 2022
|
Looks good to me, thanks! r=me once Ci pass |
Nemo157
force-pushed
the
gate-rustdoc-missing-examples
branch
from
d09ff68
to
72cf46a
Compare
|
@bors r=GuillaumeGomez rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 12, 2022
…llaumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#100185 (Fix `ReErased` leaking into typeck due to `typeof(...)` recovery) - rust-lang#100291 (constify some `CStr` methods) - rust-lang#101677 (Add test for rust-lang#101211) - rust-lang#101723 (Impove diagnostic for `.await`ing non-futures) - rust-lang#101724 (Allow unauthenticated users to add the `const-hack` label) - rust-lang#101731 (rustdoc: improve rustdoc HTML suggestions handling of nested generics) - rust-lang#101732 (Feature gate the `rustdoc::missing_doc_code_examples` lint) - rust-lang#101735 (rustdoc: fix treatment of backslash-escaped HTML) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
bors bot
pushed a commit
to boa-dev/boa
that referenced
this pull request
Nov 4, 2022
This Pull Request updates the codebase to the newest version of rustc (1.65.0). It changes the following: - Bumps `rust-version` to 1.65.0. - Rewrites some snippets to use the new let else, ok_or_else and some other utils. - Removes the `rustdoc::missing_doc_code_examples` allow lint from our codebase. (Context: rust-lang/rust#101732)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the lint from being implicitly active on nightly
rustdocto requiring a feature to activate, like other unstable lints.Uses the new tracking issue #101730