Use function pointers instead of macro-unrolled loops in rustc_query_impl

[jyn514]

By making these standalone functions, we
a) allow making them extensible in the future with a new QueryStruct
b) greatly decrease the amount of code in each individual function, avoiding exponential blowup in llvm

Helps with #96524. Based on #101173; only the last commit is relevant.

r? @cjgillot

[jyn514]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 8d113ae658eec2feb3a5be0a782eabbfacfb0f2b with merge 98f9eb27dc66cd8fc5cc582c9e65d58a407ed646...

[bors]

☀️ Try build successful - checks-actions
Build commit: 98f9eb27dc66cd8fc5cc582c9e65d58a407ed646 (98f9eb27dc66cd8fc5cc582c9e65d58a407ed646)

[rust-timer]

Queued 98f9eb27dc66cd8fc5cc582c9e65d58a407ed646 with parent 17cbdfd, future comparison URL.

[rust-timer]

Finished benchmarking commit (98f9eb27dc66cd8fc5cc582c9e65d58a407ed646): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.0%	[4.0%, 4.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Footnotes

1. the arithmetic mean of the percent change ↩

2. number of relevant changes ↩

[cjgillot]

@bors r+

[bors]

📌 Commit 7a83690 has been approved by cjgillot

It is now in the queue for this repository.

[bors]

⌛ Testing commit 7a83690 with merge 3288d3a...

[bors]

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 3288d3a to master...

[rust-timer]

Finished benchmarking commit (3288d3a): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.2%	[1.2%, 1.2%]	2
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.4%]	1
Improvements ✅ (secondary)	-1.1%	[-1.5%, -0.6%]	9
All ❌✅ (primary)	-0.4%	[-0.4%, -0.4%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.2%	[2.2%, 4.5%]	3
Improvements ✅ (primary)	-2.0%	[-2.0%, -2.0%]	1
Improvements ✅ (secondary)	-1.9%	[-2.9%, -1.6%]	4
All ❌✅ (primary)	-2.0%	[-2.0%, -2.0%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	2.7%	[2.5%, 3.0%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.7%	[2.5%, 3.0%]	2

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³

[nnethercote]

The pre-merge perf run had no significant results, and the post-merge one has only a few significant results, with the improvements slightly outweighing the regressions.

@rustbot label: +perf-regression-triaged