Disallow defaults on type GATs #101807
Merged
Disallow defaults on type GATs #101807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
This will probably also need a beta backport for the soon to branch beta, right? |
This comment has been minimized.
This comment has been minimized.
|
r? rust-lang/compiler |
lcnr
reviewed
Sep 14, 2022
compiler/rustc_typeck/src/collect.rs
Outdated
Comment on lines
1697
to
1698
| "defaults for type parameters are only allowed in \ | ||
| `struct`, `enum`, `type`, or `trait` definitions", |
There was a problem hiding this comment.
can you put that string into a const?
There was a problem hiding this comment.
Maybe it can be made translatable right away? E.g. like this: 7ef610c
There was a problem hiding this comment.
I'm really short on time this week. I'd rather get this in now, because don't want to miss beta cutoff.
|
r? @lcnr |
|
@est31 should be fine, can get this in before branch |
jackh726
force-pushed
the
no-gat-defaults
branch
from
c8bd1ff to
f1aafbd
Compare
This comment has been minimized.
This comment has been minimized.
jackh726
force-pushed
the
no-gat-defaults
branch
from
f1aafbd to
d657d1f
Compare
|
@bors r=lcnr |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 16, 2022
Disallow defaults on type GATs Fixes rust-lang#99205
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 17, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#93628 (Stabilize `let else`) - rust-lang#98441 (Implement simd_as for pointers) - rust-lang#101790 (Do not suggest a placeholder to const and static without a type) - rust-lang#101807 (Disallow defaults on type GATs) - rust-lang#101915 (doc: fix redirected link in `/index.html`) - rust-lang#101931 (doc: Fix a typo in `Rc::make_mut` docstring) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99205