-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clippy pre beta branch fix #101811
Clippy pre beta branch fix #101811
Conversation
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
@bors r+ p=1 |
📌 Commit c5cbc777afb829674d6247a07650091e99bf6ab7 has been approved by It is now in the queue for this repository. |
fwiw, I think I found another FP for the same lint rust-lang/rust-clippy#9480 |
⌛ Testing commit c5cbc777afb829674d6247a07650091e99bf6ab7 with merge 76281daa0a646c6f8861f75885d4a8efc288b354... |
@bors r- retry I think I just move it to nursery for this release then. |
Done! Let's let the fixes ride the release train 🚂 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Approving myself to get it in before tomorrow. @bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (00fcc82): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
Clippy pre beta branch fix Before beta is branched on Friday, I want to move the `unused_peekable` lint that was added in this release cycle (1.65) to `nursery`. This lint was already reported twice (rust-lang/rust-clippy#9456, rust-lang/rust-clippy#9462) in a short time, so it is probably a good idea to fix it before it hits beta and then stable. r? `@Manishearth`
Before beta is branched on Friday, I want to move the
unused_peekable
lint that was added in this release cycle (1.65) tonursery
. This lint was already reported twice (rust-lang/rust-clippy#9456, rust-lang/rust-clippy#9462) in a short time, so it is probably a good idea to fix it before it hits beta and then stable.r? @Manishearth