Skip to content

Conversation

WaffleLapkin
Copy link
Member

This PR allows building rust-analyzer-proc-macro-srv as a standalone tool via x b proc-macro-srv-cli (I thought that x b rust-analyzer-proc-macro-srv should work, but it doesn't for some reason...). Also this PR adds a copy of rust-analyzer-proc-macro-srv binary to build/{triple}/{stage}/libexec/ when building rust-analyzer-proc-macro-srv, so that r-a can pick it up.

This is useful to make r-a (and I assume Intellij IDEA) to expand macros when using a custom, build from source toolchain.

r? @jyn514
zulip thread

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Sep 15, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 15, 2022
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This makes sense to me. Can you also make a PR to the dev guide suggesting that people build this when they make a custom toolchain? It should go near the suggested workflow section, where we already have page about rustup.

@WaffleLapkin
Copy link
Member Author

dev guide PR: rust-lang/rustc-dev-guide#1467

@jyn514
Copy link
Member

jyn514 commented Sep 16, 2022

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Sep 16, 2022

📌 Commit 9c3c88c has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 17, 2022
…v, r=jyn514

Allow building `rust-analyzer-proc-macro-srv` as a standalone tool

This PR allows building `rust-analyzer-proc-macro-srv` as a standalone tool via `x b proc-macro-srv-cli` (I thought that `x b rust-analyzer-proc-macro-srv` should work, but it doesn't for some reason...). Also this PR adds a copy of `rust-analyzer-proc-macro-srv` binary to `build/{triple}/{stage}/libexec/` when building `rust-analyzer-proc-macro-srv`, so that r-a can pick it up.

This is useful to make r-a (and I assume Intellij IDEA) to expand macros when using a custom, build from source toolchain.

r? `@jyn514`
[_zulip thread_](https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Frust-analyzer/topic/How.20to.20fix.20.60UnsupportedABI.60.20for.20custom.20toolchains.3F/near/299040175)
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 17, 2022
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#101672 (array docs - advertise how to get array from slice)
 - rust-lang#101781 (Extend list of targets that support dyanmic linking for llvm tools)
 - rust-lang#101783 (Improve handing of env vars during bootstrap process)
 - rust-lang#101801 (add note for `layout_of` when query depth overflows)
 - rust-lang#101824 (rustdoc: add test cases for turning ``[Vec<T>]`` into ``[`Vec<T>`]``)
 - rust-lang#101861 (Update stdarch)
 - rust-lang#101873 (Allow building `rust-analyzer-proc-macro-srv` as a standalone tool)
 - rust-lang#101918 (rustdoc: clean up CSS for All Items and All Crates lists)
 - rust-lang#101934 (Continue migration of CSS themes)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 179fd13 into rust-lang:master Sep 17, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 17, 2022
@WaffleLapkin WaffleLapkin deleted the x-build-proc-macro-srv branch September 18, 2022 10:53
@cuviper cuviper modified the milestones: 1.65.0, 1.66.0 Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants